Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Get for SQL DB #13

Merged
merged 4 commits into from
Jan 30, 2022
Merged

implement Get for SQL DB #13

merged 4 commits into from
Jan 30, 2022

Conversation

elh
Copy link
Owner

@elh elh commented Jan 30, 2022 •
edited
Loading

  • implement Get
  • provide generic ScanToVersionedKVs and ScanToMaps helpers

Test improvements (pattern to be applied to other test changes)

  • update TestGet to be parameterized by values appropriate for DB implementation type.
  • update TestGet to take a dbFn that returns both the seeded db and a close function
  • clean up test DB set up

@elh elh merged commit cd4d03f into main Jan 30, 2022
@elh elh deleted the get-sql branch January 30, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elh