Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale dimensions if we have a physical monitor layout #566

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

leolost2605
Copy link
Member

Fixes #562
Closes #563

@leolost2605 leolost2605 requested a review from danirabbit August 16, 2024 23:40
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this branch I can confirm the panel size is correct with:

✔️ Wayland on HiDPI
✔️ Wayland on LoDPI
✔️ X11 on LoDPI

but

❌ X11 on HiDPI I get small panel

update ();
}

private static void update () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return true early if we're on X11?

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge this because it's better than the current situation and panel is blocking other things

@danirabbit danirabbit enabled auto-merge (squash) August 21, 2024 16:50
@danirabbit danirabbit merged commit 5393390 into master Aug 21, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/scale-if-physical branch August 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most indicators missing on Wayland
2 participants