Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focussing terminal after select #846

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 6, 2025

Fixes #845

Wait for default handler before term grab_focus ()

@vjr vjr requested a review from a team February 6, 2025 01:29
@vjr vjr marked this pull request as ready for review February 6, 2025 01:30
Copy link
Member

@vjr vjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and works for me.

@vjr
Copy link
Member

vjr commented Feb 6, 2025

@jeremypw this PR works for me - why was it in draft status? i marked it ready-for-review and approved it - so unless there's something further pending - please go ahead and merge.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Feb 6, 2025

@vjr Thanks for the review! I usually leave PRs in draft while I test them and also to limit the number of review requests pending. Looks like I have neglected to mark some more PRs as ready in this repo.

@jeremypw jeremypw merged commit 905904e into master Feb 6, 2025
4 checks passed
@jeremypw jeremypw deleted the jeremypw/focus-after-select branch February 6, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal Tabs require 3 tab key presses to get focus
2 participants