Application: Implement startup()
#710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handy initialization and css loading is done here now, the new-window and quit action are implemented here too since there's no reason for them to be part of the window class. one behaviour diferrence is that the quit action now closes all windows instead of only the current window matching others elementary applications.
jeremypw
requested changes
Mar 19, 2023
jeremypw
requested changes
Apr 2, 2023
|
For me it was failing in the "quit" action test. I tried to fix it but failed. We could always leave that test out and fix it later if necesssary. |
|
#720 now merged ... but CI still failing 😞 However, CI passed locally 🤷♂️ |
|
Hmm, contrary to my previous diagnosis the CI is (now) failing on the "new-window" action test. See #723 |
the new-window test is fine, |
jeremypw
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handy initialization and CSS loading is done here now, the
new-windowandquitaction are implemented here too since there's no reason for them to be part of the window class. one behaviour diference is that the quit action now closes all windows instead of only the current window matching others elementary applications.