Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for Your Communities scrollbar #5501

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

lukebarnard1
Copy link
Contributor

and also attempt to fix GroupTile flex weirdness.

and also attempt to fix GroupTile flex weirdness.
@@ -61,10 +64,21 @@ limitations under the License.
/* Until the button is wired up */
.mx_MyGroups_joinBox {
visibility: hidden;
height: 0px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come the 0 height here?

@ara4n
Copy link
Member

ara4n commented Nov 3, 2017

lgtm other than wanting a comment on the height: 0px, which is a sufficiently magical/fragile thing to do that it's probably worth saying why

@lukebarnard1 lukebarnard1 merged commit 2c4c6e8 into develop Nov 3, 2017
@t3chguy t3chguy deleted the luke/groups-fix-my-groups-layout branch May 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants