Pass current language into Jitsi (#24609 #24609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
3 tasks
Jitsi itself now uses the current language of the user. However, this does not yet apply to the welcome page of the Jitsi widget that says "Join conference", which is only hard-coded to english for now. Signed-off-by: Oliver Sand <oliver.sand@nordeck.net>
Fox32
force-pushed
the
nic/feat/jitsi-language
branch
from
f371ba7 to
7515695
Compare
|
Please avoid force pushing, it discards existing review state and means I can't just review diffs. We squash merge anyway so don't worry about making a mess of the commits |
t3chguy
reviewed
Feb 22, 2023
|
We don't have test infra set up for the jitsi wrapper yet, skipping requirement |
t3chguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jitsi itself now uses the current language of the user. However, this does not yet apply to the welcome page of the Jitsi widget that says "Join conference", which is only hard-coded to english for now.
This pulls out some changes from #23412 which seems to be unlikely to be merged soon.
Signed-off-by: Oliver Sand oliver.sand@nordeck.net
Checklist
Type: enhancement
Here's what your changelog entry will look like:
✨ Features