-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compound color refinements #26992
Comments
As I'm in discussion with Nad about https://github.com/element-hq/element-internal/issues/536 I'd like to make sure that we're not creating / implementing facts before there is a clear direction. |
Interesting, that discussion would primarily bring matrix-org/matrix-react-sdk#12241 in question, which changes our green actions to be black and white. Do we need to revert that change? The retainer work package linked to this issue would then likely become blocked on https://github.com/element-hq/element-internal/issues/536, for the record. @gaelledel Do you have thoughts on how we should proceed? |
I think this requires guidance and alignment with @nadonomy |
This is a reintroduction of matrix-org#12255, and should be the last part of the Compound color refinement work (element-hq/element-web#26992). I've updated the following components to reflect design decisions (https://www.figma.com/file/pqhlirZFEwEp5XpudSbiia/Theming-Web-templates?type=design&node-id=80-60219&mode=design&t=mjqwylUie1vRwzOV-0) that will help them fit in better with the new design system: - Message bubbles - Pills - Sent indicators - Jump to bottom/unread buttons - Composer placeholder - Notification badges - Room sublists - Verification shields - Date separators - Tooltips Closes element-hq/element-web#22122
* Refine the colors of some more components This is a reintroduction of #12255, and should be the last part of the Compound color refinement work (element-hq/element-web#26992). I've updated the following components to reflect design decisions (https://www.figma.com/file/pqhlirZFEwEp5XpudSbiia/Theming-Web-templates?type=design&node-id=80-60219&mode=design&t=mjqwylUie1vRwzOV-0) that will help them fit in better with the new design system: - Message bubbles - Pills - Sent indicators - Jump to bottom/unread buttons - Composer placeholder - Notification badges - Room sublists - Verification shields - Date separators - Tooltips Closes element-hq/element-web#22122 * Update some screenshots
Element Web is using colors from Compound, but since these were originally applied on a best-effort basis, we're finding that their usage does not always match their intended semantics. This is particularly relevant for users of custom themes, who may see unexpected results where we've applied the wrong semantic color tokens. Additionally, as we continue to integrate more Compound components into Element Web, we could stand to improve Element Web's visual coherency by updating the colors of some existing components.
@gaelledel and I have paired to review Element Web's color usage, and we discovered a number of things that we'd like to revise (Figma). As with the original color pass, these are to be incremental improvements, as we can't realistically check every variation of every component.
Tasks
The text was updated successfully, but these errors were encountered: