Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jitsi wrapper size is insanely large #12839

Closed
turt2live opened this issue Mar 24, 2020 · 2 comments · Fixed by #12845
Closed

Jitsi wrapper size is insanely large #12839

turt2live opened this issue Mar 24, 2020 · 2 comments · Fixed by #12845
Assignees
@turt2live
Labels
A-Jitsi A-Performance A-Widgets T-Defect T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

30mb to load about 1kb of code. We should look at tree shaking or better dependency chains.
@turt2live turt2live mentioned this issue Mar 24, 2020
Merged
@turt2live
Copy link
Member Author

Actually it looks like the linked PR fixed the issue:
image

It's a production build, but 8kb isn't that bad.

cc @jryans

@turt2live
Copy link
Member Author

and reopening because I've reverted the PR: #12842

@turt2live turt2live reopened this Mar 24, 2020
@turt2live turt2live self-assigned this Mar 24, 2020
turt2live added a commit that referenced this issue Mar 24, 2020
@turt2live
Ask for Riot config over postMessage for the Jitsi widget
bde5679 
Fixes #12839 by not using the app load order that doesn't detect the right platform anyways.
@turt2live turt2live mentioned this issue Mar 24, 2020
Merged
@Fox32 Fox32 mentioned this issue Oct 6, 2022
Closed
3 tasks
t3chguy added a commit that referenced this issue Oct 17, 2024
@t3chguy
Rework how the onboarding notifications task works (#12839)
0204724 
* Rework how the onboarding notifications task works

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add test

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Jitsi A-Performance A-Widgets T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Jitsi wrapper being large by getting the config from elsewhere element-hq/element-web
1 participant
@turt2live