Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session manager] Other sessions list: header should not be sticky (PSG-1115) #7804

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

In the other sessions list screen, making the header as collapsable so that it gives more place to the list.

Motivation and context

Closes #7797

Screenshots / GIFs

Tests

  • Enable the labs setting for the new session manager
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Press the View All button in the Other sessions section (need more than 5 other sessions)
  • Check the scrolling behavior of the list and the header with the different filter options

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 16, 2022 09:05
@mnaturel mnaturel requested review from a team and fedrunov and removed request for a team December 16, 2022 09:05
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mnaturel mnaturel merged commit 2b9f5c4 into develop Dec 16, 2022
@mnaturel mnaturel deleted the feature/mna/make-other-sessions-header-not-sticky branch December 16, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Session manager] Other sessions list: header should not be sticky
2 participants