Fix some quoted messages having 'null' message bodies #7532

jmartinesp · 2022-11-07T10:47:51Z

Type of change

Feature
Bugfix (SDK)
Technical
Other :

Content

LocalEchoEventFactory.createQuotedTextEvent incorrectly handled messages with no formatted text in quotes.

Motivation and context

Fixes #7530 .

Screenshots / GIFs

Tests

With Rich Text Editor disabled (using the default composer), type a message.
Quote this message.
Then enable markdown formatting (Settings > Preferences).
Quote the previous message using some MD formatting (bold, italic, etc.).
Create a new MD message, quote it too with no markdown in the new text.

No "null" text should appear and formatting should look good (correct new line after quote, etc.).

Tested devices

Physical
Emulator
OS version(s): API 29

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

onurays · 2022-11-09T11:42:09Z

...oid/src/main/java/org/matrix/android/sdk/internal/session/room/send/LocalEchoEventFactory.kt

+
+        val plainTextBody = buildString {
+            val plainMessageParagraphs = quotedText?.split("\n\n".toRegex())?.dropLastWhile { it.isEmpty() }?.toTypedArray().orEmpty()
+            for ((i, paragraph) in plainMessageParagraphs.withIndex()) {
