Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing buildjet Emulator network #7210

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Sep 22, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes the CantVerifyTest failing when running on the buildjet github action runner, the cause seems to be related to the emulator not having access to the wider network, which meant the initial matrix.org requests would timeout.

For reasons unknown to me, switching the emulator image to use the play store version ensures that the outside network is accessible.

Motivation and context

To re-enable an ignored test

Screenshots / GIFs

No production code changes

Tests

Run on the CI!

Tested devices

  • Physical
  • Emulator
  • OS version(s):

@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from ac8ce1c to 7952439 Compare September 22, 2022 14:38
@ouchadam ouchadam changed the base branch from develop to feature/adm/coroutine-instrumentation September 22, 2022 14:38
@ouchadam ouchadam force-pushed the feature/adm/coroutine-instrumentation branch from 955ac8d to ad8786d Compare September 22, 2022 14:41
@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from 7952439 to 35b1ba3 Compare September 22, 2022 14:42
@ouchadam ouchadam force-pushed the feature/adm/coroutine-instrumentation branch from ad8786d to 1db0ef4 Compare September 23, 2022 10:14
@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch 2 times, most recently from b03d43a to aee2c71 Compare September 23, 2022 13:25
@ouchadam ouchadam force-pushed the feature/adm/coroutine-instrumentation branch from 1db0ef4 to 3f83afb Compare September 23, 2022 13:26
@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from aee2c71 to 21ba60e Compare September 23, 2022 13:27
@ouchadam ouchadam changed the title [CI TEST] Emulator network access Missing buildjet Emulator network Sep 23, 2022
@ouchadam ouchadam added the PR-Small PR with less than 20 updated lines label Sep 23, 2022
@ouchadam ouchadam marked this pull request as ready for review September 23, 2022 13:35
@ouchadam ouchadam requested review from a team and mnaturel and removed request for a team September 23, 2022 13:35
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from 21ba60e to 2f9c5f5 Compare September 26, 2022 09:17
@ouchadam ouchadam changed the base branch from feature/adm/coroutine-instrumentation to develop September 26, 2022 09:17
@ouchadam ouchadam enabled auto-merge September 26, 2022 09:17
@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from 2f9c5f5 to 34b3c6c Compare September 26, 2022 11:03
…n the buildjet runner

- updates max workers to match available resources
- re-enables previously failing test
@ouchadam ouchadam force-pushed the feature/adm/emulator-network-access branch from 34b3c6c to 2e4ca1d Compare September 26, 2022 11:29
~/.android/adb*
key: avd-${{ matrix.api-level }}

- name: create AVD and generate snapshot for caching
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caching the AVD is causing strange problems for the playstore emulator image where the expected AVD path changes between runs

PANIC: Broken AVD system path. Check your ANDROID_SDK_ROOT value [/usr/local/lib/android/sdk]!

Creating a new AVD image each run fixes the problem but does mean the initial start time becomes slower

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ouchadam ouchadam merged commit df752b9 into develop Sep 26, 2022
@ouchadam ouchadam deleted the feature/adm/emulator-network-access branch September 26, 2022 12:39
@ouchadam ouchadam mentioned this pull request Sep 26, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants