Display specific message when verif code malformed #6395
Conversation
BillCarsonFr
requested review from
a team,
onurays and
bmarty
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -84,7 +84,7 @@ internal class DefaultQrCodeVerificationTransaction( | |||
| // Perform some checks | |||
| if (otherQrCodeData.transactionId != transactionId) { | |||
| Timber.d("## Verification QR: Invalid transaction actual ${otherQrCodeData.transactionId} expected:$transactionId") | |||
| cancel(CancelCode.QrCodeInvalid) | |||
| cancel(CancelCode.UnknownTransaction) | |||
There was a problem hiding this comment.
It's worth noting that UnknownTransaction was never used.
That said, it looks that this change is not triggering the usage of ConclusionState.INVALID_QR_CODE.
I would have split the 2 changes into 2 distinct commits, or am I missing something?
There was a problem hiding this comment.
Yeah I lowered the warning level when the QR code is malformed. But in this case the QR code is valid but it's not the right transaction Id, so it looks like it's more worrying than just a format error, so I still want it to have the old warning, it would appear has a compromised modal.
There was a problem hiding this comment.
OK, I understand the same thing. 2 commits would have been better :).
Also this case can happen if I scan any other unrelated but well formatted verification QR code, so maybe in this case, this is probably not really a compromission, so we may just show something like "this is not the expected QR code" and cancel the verification. Not sure if we want to bother more about that.
Type of change
Content
When scanning an invalid (malformed) QR code during a user verification, the application will display the compromised warning modal. It looks like this warning is a bit too much compared to other reason like mismatched keys or users.
And given that some mobile clients can have issues decoding some QR code it's worth it to create a specific screen.
So now instead a specific warning is shown for QR code format issues
Motivation and context
Screenshots / GIFs
Tests
Step 1
Step 2
Step ...
Tested devices
Checklist