-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK - Logout all devices #6207
SDK - Logout all devices #6207
Conversation
2f51280
to
edfabb0
Compare
e2abbc9
to
3c3bd77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just to understand - when we logout user from all sessions we do that only server-side? There is no event coming from server to clients, which we need to handle? Like push notification to let user know that they was logged out and won't receive notifications anymore? |
Correct, it's server controlled, there's no real-time push event but the users token is invalidated and they'll receive a 401 the next time they attempt to make a request with their locally stored token (which the clients already handle) for context, logging out from all sessions is the current default behaviour for Android, the change in this PR enables the SDK to opt out |
- adds reset test cases to the onboarding view model
…ting the reset process
… for the UI to take it into account
…Capabilities - Includes DB version update and HomeserverCapability migration
…server state via the LoginFlowResult
…model from the entity
…ing reset password
7a633a4
to
e655a54
Compare
SonarCloud Quality Gate failed. |
Draft as this depends on #6171
Type of change
Content
#6191 Adding SDK support for MSC2457 - opting in/out of logging out of all devices when changing password
HomeserverCapabilities.canControlLogoutDevices
fieldMotivation and context
To enable the next steps of the FTUE forgotten password flow to introduce a new sign out all devices check box.
Screenshots / GIFs
no UI changes here, is made use of in #6263
Tests
No logic changes
Tested devices