-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Location Sharing - Beacon Info #5651
Changes from 5 commits
32cf3fe
152c921
6952552
2a4182e
922d68c
97de6de
273b481
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Send beacon info state event when live location sharing started |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2020 The Matrix.org Foundation C.I.C. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.matrix.android.sdk.api.session.room.model | ||
|
||
import com.squareup.moshi.Json | ||
import com.squareup.moshi.JsonClass | ||
|
||
@JsonClass(generateAdapter = true) | ||
data class BeaconInfo( | ||
@Json(name = "description") val description: String? = null, | ||
/** | ||
* Beacon should be considered as inactive after this timeout as milliseconds. | ||
*/ | ||
@Json(name = "timeout") val timeout: Long? = null, | ||
/** | ||
* Should be set true to start sharing beacon. | ||
*/ | ||
@Json(name = "live") val isLive: Boolean? = null | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright 2020 The Matrix.org Foundation C.I.C. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment about the date. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.matrix.android.sdk.api.session.room.model | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should create a dedicated subpackage for models concerning the live location feature? For instance There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking about this, done. |
||
|
||
import com.squareup.moshi.Json | ||
import com.squareup.moshi.JsonClass | ||
import org.matrix.android.sdk.api.session.room.model.message.LocationAsset | ||
|
||
@JsonClass(generateAdapter = true) | ||
data class LiveLocationBeaconContent( | ||
/** | ||
* Indicates user's intent to share ephemeral location. | ||
*/ | ||
@Json(name = "org.matrix.msc3489.beacon_info") val unstableBeaconInfo: BeaconInfo? = null, | ||
@Json(name = "m.beacon_info") val beaconInfo: BeaconInfo? = null, | ||
/** | ||
* Beacon creation timestamp. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if we do it in other places, but it might be handy to know the timestamp format, for example epoch seconds or milliseconds There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed and used clock class. |
||
*/ | ||
@Json(name = "org.matrix.msc3488.ts") val unstableTimestampAsMilliseconds: Long? = null, | ||
@Json(name = "m.ts") val timestampAsMillisecond: Long? = null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to unify the naming? Indeed, the unstable field has an ending "s" in its name and the stable one has no ending "s". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch, done. |
||
/** | ||
* Live location asset type. | ||
*/ | ||
@Json(name = "org.matrix.msc3488.asset") val unstableLocationAsset: LocationAsset = LocationAsset("m.self"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to use the defined const value There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, it has been changed. Done. |
||
@Json(name = "m.asset") val locationAsset: LocationAsset? = null | ||
) { | ||
|
||
fun getBestBeaconInfo() = beaconInfo ?: unstableBeaconInfo | ||
|
||
fun getBestTimestampAsMilliseconds() = timestampAsMillisecond ?: unstableTimestampAsMilliseconds | ||
|
||
fun getBestLocationAsset() = locationAsset ?: unstableLocationAsset | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,18 @@ import android.content.Intent | |
import android.os.IBinder | ||
import android.os.Parcelable | ||
import dagger.hilt.android.AndroidEntryPoint | ||
import im.vector.app.core.di.ActiveSessionHolder | ||
import im.vector.app.core.services.VectorService | ||
import im.vector.app.core.time.Clock | ||
import im.vector.app.features.notifications.NotificationUtils | ||
import im.vector.app.features.session.coroutineScope | ||
import kotlinx.coroutines.launch | ||
import kotlinx.parcelize.Parcelize | ||
import org.matrix.android.sdk.api.session.Session | ||
import org.matrix.android.sdk.api.session.events.model.EventType.generateBeaconInfoStateEventType | ||
import org.matrix.android.sdk.api.session.events.model.toContent | ||
import org.matrix.android.sdk.api.session.room.model.BeaconInfo | ||
import org.matrix.android.sdk.api.session.room.model.LiveLocationBeaconContent | ||
import timber.log.Timber | ||
import java.util.Timer | ||
import java.util.TimerTask | ||
|
@@ -40,6 +49,8 @@ class LocationSharingService : VectorService(), LocationTracker.Callback { | |
|
||
@Inject lateinit var notificationUtils: NotificationUtils | ||
@Inject lateinit var locationTracker: LocationTracker | ||
@Inject lateinit var activeSessionHolder: ActiveSessionHolder | ||
@Inject lateinit var clock: Clock | ||
|
||
private var roomArgsList = mutableListOf<RoomArgs>() | ||
private var timers = mutableListOf<Timer>() | ||
|
@@ -67,11 +78,40 @@ class LocationSharingService : VectorService(), LocationTracker.Callback { | |
|
||
// Schedule a timer to stop sharing | ||
scheduleTimer(roomArgs.roomId, roomArgs.durationMillis) | ||
|
||
// Send beacon info state event | ||
activeSessionHolder | ||
.getSafeActiveSession() | ||
?.let { session -> | ||
session.coroutineScope.launch { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it would be better to precise the IO Dispatcher here like this:
I am not sure but reading the implementation of SessionCoroutineScopes, it seems the default Dispatcher is the Main one. @ouchadam or @bmarty could you confirm? Or am I missing something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am also not so confident, but IO seems better. @bmarty? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I thought this would have triggered a network on main thread warning 🤔 |
||
sendBeaconInfo(session, roomArgs) | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to double check: this code does not send multiple beacon events during a period of time, but just one event, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, location events will be sent later. |
||
} | ||
|
||
return START_STICKY | ||
} | ||
|
||
private suspend fun sendBeaconInfo(session: Session, roomArgs: RoomArgs) { | ||
val beaconContent = LiveLocationBeaconContent( | ||
unstableBeaconInfo = BeaconInfo( | ||
timeout = roomArgs.durationMillis, | ||
isLive = true | ||
), | ||
unstableTimestampAsMilliseconds = clock.epochMillis() | ||
).toContent() | ||
|
||
val eventType = generateBeaconInfoStateEventType(session.myUserId) | ||
val stateKey = session.myUserId | ||
session | ||
.getRoom(roomArgs.roomId) | ||
?.sendStateEvent( | ||
eventType = eventType, | ||
stateKey = stateKey, | ||
body = beaconContent | ||
) | ||
} | ||
|
||
private fun scheduleTimer(roomId: String, durationMillis: Long) { | ||
Timer() | ||
.apply { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the date to 2022?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch :) Done.