Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity test getting stuck on account created screen #5610

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Updates the account creation flow in the sanity test, taking into account the new account created (congratulations!) screen

Motivation and context

originally part of #5519

Screenshots / GIFs

GIF
after-account-creation

Tests

  • Run the sanity tests
  • See the tests get stuck on the account created screen

Tested devices

  • Physical
  • Emulator
  • OS version(s): 32 Sv2

- adds tapping the new take me home button within the sanity test
@github-actions
Copy link

Unit Test Results

106 files  ±0  106 suites  ±0   1m 16s ⏱️ ±0s
188 tests ±0  188 ✔️ ±0  0 💤 ±0  0 ±0 
622 runs  ±0  622 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5bbc9dc. ± Comparison against base commit 951171c.

@ouchadam ouchadam requested a review from ganfra March 23, 2022 09:45
@ouchadam
Copy link
Contributor Author

does this need a changelog entry? 🤔

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! no need for changelog

@ganfra ganfra merged commit 20b2af4 into develop Mar 23, 2022
@ganfra ganfra deleted the feature/adm/account-creation-sanity-test-update branch March 23, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants