Giving avatar/display name error dialogs human readable error messages #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reuses the ErrorDialog logic which translates exceptions to human readable strings
ouchadam
force-pushed
the
feature/adm/settings-error-dialog
branch
from
5f0b0db to
54e23a2
Compare
bmarty
approved these changes
Mar 3, 2022
| * @param errorMessage the error message | ||
| */ | ||
| protected fun onCommonDone(errorMessage: String?) { | ||
| if (!isAdded) { |
There was a problem hiding this comment.
This check is lost. Now we should probably use launchWhenResumed. If the operation takes time and the user leave the screen before it ends we can have crashes.
EDIT My bad, we are already in the lifecycleScope, so I guess it's fine
There was a problem hiding this comment.
yep exactly ^^^ seemed like left over code from before coroutines were introduced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Reuses the error dialog logic which translates exceptions to human readable strings in the settings screen
Motivation and context
Fixes #5418 - The error messages for display name/avatar changing are making use of the raw exception instead of the nicely formatted message included within the exception
Screenshots / GIFs
Tests
Tested devices