Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 3pid invite #548

Open
6 of 11 tasks
bmarty opened this issue Sep 6, 2019 · 2 comments
Open
6 of 11 tasks

[Feature] 3pid invite #548

bmarty opened this issue Sep 6, 2019 · 2 comments

Comments

@bmarty
Copy link
Member

bmarty commented Sep 6, 2019

As specced here

The app should:

  • Render the m.room.third_party_invite event in the timeline

To send invite, the app should:

  • Send invite to an email with /invite command
  • Send invite to a Msisdn with /invite command -> We get an error 500 {"errcode":"M_UNKNOWN","error":"Internal server error"}
  • In the room member list, access the phone contacts to be able to invite them
  • by email
  • by phone
  • by Matrix ID thanks to identity server lookup

Also:

  • If power level is high enough, user should be able to revoke a 3pid invite

When receiving an invite, the user click on the link and the app should:

  • If the app is not installed: offer to install the app (redirect to the store?). Currently I think the riot.im web instance will be opened. The mail should propose to install the app.
  • If the user is not logged in: the user should be able to create an account or to log in and see the invite once he has bound his 3pid to the account
  • If the user is already logged in: the user should be able to see the invite if the 3pid is bound to his account

EDIT: First PR will handle all the checkbox above. Msisdn support is deactivated for the moment

@bmarty bmarty added this to the Phase 2 milestone Sep 6, 2019
@bmarty bmarty self-assigned this Jan 10, 2020
@bmarty
Copy link
Member Author

bmarty commented Jan 14, 2020

Unfortunately it requires to implement the identity server part (#607), which has not been identified as a showstopper.

@bmarty bmarty mentioned this issue May 5, 2020
20 tasks
bmarty added a commit that referenced this issue Jul 7, 2020
bmarty added a commit that referenced this issue Jul 8, 2020
WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)
bmarty added a commit that referenced this issue Jul 8, 2020
bmarty added a commit that referenced this issue Jul 9, 2020
@bmarty bmarty mentioned this issue Jul 10, 2020
bmarty added a commit that referenced this issue Jul 11, 2020
bmarty added a commit that referenced this issue Jul 11, 2020
WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)
bmarty added a commit that referenced this issue Jul 11, 2020
bmarty added a commit that referenced this issue Jul 11, 2020
onurays added a commit that referenced this issue Jul 15, 2020
* riotx_develop: (111 commits)
  Video calls are shown as a voice ones in the timeline (Fixes #1676)
  Fix regression: not able to create a room without IS configured (Fixes #1679)
  Fix / view attachment crash + freeze when offline
  Version++
  Prepare release 0.91.5
  Fix test compilation issue
  Fix crash after rebase
  Add TODO
  Copy Javadoc to the API class
  Move internal methods to internal task
  Latest renaming
  Rename CreateRoomParamsInternalBuilder to CreateRoomBodyBuilder for clarity
  Rename CreateRoomParamsBuilder to CreateRoomParams for clarity
  Rename internal class
  Expose other objects in the builder to create a room
  ktlint
  Display threePid invite along with the other invite (code is a bit dirty)
  Hide right arrow if threepid invite can not be revoked
  Disable fetching Msisdn, it does not work
  Revoke ThreePid invitation (#548)
  ...

# Conflicts:
#	vector/build.gradle
#	vector/src/main/java/im/vector/riotx/features/crypto/keys/KeysExporter.kt
#	vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml
#	vector/src/main/res/values/strings.xml
@henry-nicolas
Copy link

Are there any plans for the 3pid invite by phone feature?

It feels weird when one want to invite another user by doing a contact lookup and no result pops up.
On Android (phones, arguably not on tablets form factors), contacts would have their phone number fields filed in, making this feature very relevant imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants