Fix ordering issues in requesting backfill #3530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a map means the orders are processed in an indeterminate order, which causes a lot of `/state_ids` requests as the `prev_events` are not known when the order is lost. Also topologically sort results from multiple servers when doing a `RequestBackfill` just to be safe, since otherwise results retrieved from multiple servers could end up out-of-order too. Signed-off-by: Neil Alexander <git@neilalexander.dev>
Signed-off-by: Neil Alexander <git@neilalexander.dev>
neilalexander
force-pushed
the
neil/backfill
branch
from
80ade37 to
56bc4a9
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
==========================================
- Coverage 49.41% 49.40% -0.02%
==========================================
Files 524 524
Lines 59817 59817
==========================================
- Hits 29556 29550 -6
- Misses 26772 26783 +11
+ Partials 3489 3484 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a map means the events are processed in an indeterminate order, which causes a lot of
/state_idsrequests as theprev_eventsare not known when the order is lost.Signed-off-by: Neil Alexander git@neilalexander.dev