Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] add demo-component as dependency #728

Merged
merged 1 commit into from
Mar 6, 2018
Merged

[patch] add demo-component as dependency #728

merged 1 commit into from
Mar 6, 2018

Conversation

didi0613
Copy link
Contributor

@didi0613 didi0613 commented Feb 21, 2018 •
edited
Loading

Inside index.js, we import component-playground as a direct usage here: https://github.com/didi0613/electrode/blob/9762bdc8c34fa7ac1e532ae77219d66aa8fdb55c/samples/electrode-demo-index/src/index.js#L4

We need component-playground as a dependency here.

Needs this one get merged first:
#733

@didi0613 didi0613 changed the title add demo-component as dependency [patch] add demo-component as dependency Feb 21, 2018
datvong-wm
datvong-wm approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@datvong-wm datvong-wm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jchip jchip merged commit e6f9ff0 into electrode-io:master Mar 6, 2018
@didi0613 didi0613 deleted the demo-index-add-component-playground-back branch August 3, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datvong-wm datvong-wm datvong-wm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didi0613 @datvong-wm @jchip