Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch][archetype-app] resolve react/lib/ReactMount issue for hot reload #679

Merged
merged 3 commits into from
Jan 15, 2018
Merged

[patch][archetype-app] resolve react/lib/ReactMount issue for hot reload #679

merged 3 commits into from
Jan 15, 2018

Conversation

didi0613
Copy link
Contributor

@didi0613 didi0613 commented Jan 15, 2018 •
edited
Loading

Fix the issue for react-hot-loder

Issue: gaearon/react-hot-loader#643

Solution: Based on https://github.com/gaearon/react-hot-loader#getting-started
Upgrade react-hot-loader to v3

Verified on
screen shot 2018-01-15 at 1 25 00 pm
Home App

ajoshi0
ajoshi0 approved these changes Jan 15, 2018
View reviewed changes
Copy link

@ajoshi0 ajoshi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @didi0613

@jchip jchip merged commit d73327f into electrode-io:master Jan 15, 2018
@didi0613 didi0613 deleted the fix-hot-reload-issues branch August 3, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajoshi0 ajoshi0 ajoshi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didi0613 @ajoshi0 @jchip