Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] update generated app to React 16 #673

Merged
merged 3 commits into from
Jan 12, 2018

Conversation

didi0613
Copy link
Contributor

@didi0613 didi0613 commented Jan 12, 2018

Working demo:

screen shot 2018-01-12 at 10 17 15 am

@@ -31,9 +31,9 @@
},
"dependencies": {
"bluebird": "^3.4.6",
"electrode-archetype-react-app": "^4.0.0",
"electrode-archetype-react-app": "^5.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending on the releases of "electrode-archetype-react-app": "^5.0.0" and "electrode-react-webapp": "^3.0.0".

@didi0613 didi0613 changed the title [major] update electrode app generator to support react16 [major][do not merge] update electrode app generator to support react16 Jan 12, 2018
@jchip
Copy link
Member

jchip commented Jan 12, 2018

this will be taken care of by lerna when publishing

@jchip
Copy link
Member

jchip commented Jan 12, 2018

actually, no, not related to lerna.

@jchip jchip changed the title [major][do not merge] update electrode app generator to support react16 [major] update generated app to react16 Jan 12, 2018
@jchip jchip changed the title [major] update generated app to react16 [major] update generated app to React 16 Jan 12, 2018
@jchip jchip merged commit 50b3d7a into electrode-io:master Jan 12, 2018
@didi0613 didi0613 deleted the react-16-app-generator branch August 3, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants