Reports code coverage on server side tests #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @mcrowder65 |
|
Huh |
|
@ajoshi0 hahaha I looked up what LTGM stood for and it said “learn the game mechanics”, meaning something like you suck and have no idea what you’re doing so I was ready be like what the heck man!!! Then I looked up LGTM :) |
|
LGTM --> Looks good to me @mcrowder65 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming the user is using
"istanbul": "^1.1.0-alpha.1", this generates a code coverage report like so, as well as lcov.info file.. We can change this archetype's istanbul download to be the alpha if you want. right now code coverage doesn't work anyways... we explicitly installed istanbul in our root instead of using 0.4.5 and that's what made it work