[minor][feat] Allow inline scripts to be marked with a nonce for CSP protection #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…protection Modified react-webapp to notice when a nonce value has been provided, and if so attaches it to any <script> tags that are generated. See also https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
added 2 commits
July 18, 2017 18:06
|
The continuus-integration tests appear to have failed in generator-electrode, which is unrelated to my change. Am I reading this wrong? |
|
where are you adding the |
|
Adding it with a plugin called blankie. This is just the change to catch the value from that, or any other similar plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified react-webapp to notice when a nonce value has been provided, and if so attaches
it to any <script> tags and the critical css tag that are generated. See also https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
Fix for #474
Note: Internal feedback suggested that in some cases a function would be a more general way to get the none value, so added this as an alternative. Modified docs and tests to test both with a string and the function.