Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable for webpack dev HTTPS #290

Merged
merged 2 commits into from
Apr 22, 2017
Merged

Add environment variable for webpack dev HTTPS #290

merged 2 commits into from
Apr 22, 2017

Conversation

karlhorky
Copy link
Contributor

In our development environment we need to run the webpack asset server with HTTPS.

Would you be open to accepting a pull request to allow this to be configured in Electrode?

Run in https mode like this:

WEBPACK_DEV_HTTPS=true npm start

or add to your package.json:

{
  "scripts": {
    "start": "if test \"$NODE_ENV\" = \"production\"; then npm run prod; else WEBPACK_DEV_HTTPS=true gulp dev; fi"
  }
}

cc @FreaKzero

@jchip jchip merged commit a5f3a7c into electrode-io:master Apr 22, 2017
@karlhorky karlhorky deleted the add-flag-for-webpack-dev-https branch April 23, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants