Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate data plugin and dependencies to TS project references #87081

Closed
wants to merge 3 commits into from

Conversation

joshdover
Copy link
Contributor

Summary

Related to #80508
Depends on #87075

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover changed the title Remove dynamic mapped types from UiActions Migrate data plugin and dependencies to TS project references Dec 30, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 30, 2020

💔 Build Failed

Failed CI Steps


Test Failures

Jest Tests.src/plugins/data/common/index_patterns/index_patterns.IndexPattern toSpec should match snapshot

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `IndexPattern toSpec should match snapshot 1`

- Snapshot  - 1
+ Received  + 1

@@ -687,9 +687,9 @@
    "id": "test-pattern",
    "intervalName": undefined,
    "sourceFilters": undefined,
    "timeFieldName": "timestamp",
    "title": "title",
-   "type": "index-pattern",
+   "type": "type-pattern",
    "typeMeta": undefined,
    "version": "2",
  }
    at Object.<anonymous> (/dev/shm/workspace/parallel/5/kibana/src/plugins/data/common/index_patterns/index_patterns/index_pattern.test.ts:223:37)
    at Object.asyncJestTest (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Metrics [docs]

Distributable file count

id before after diff
default 47267 48027 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 233.0KB 233.0KB +43.0B
maps 152.7KB 152.8KB +51.0B
uiActions 63.6KB 62.3KB -1.4KB
total -1.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov
Copy link
Contributor

mshustov commented Jan 5, 2021

superseded by #87294

@mshustov mshustov closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants