Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate bfetch to TS Project References #86040

Closed
wants to merge 1 commit into from
Closed

Migrate bfetch to TS Project References #86040

wants to merge 1 commit into from

Conversation

clintandrewhall
Copy link
Contributor

Summary

Applies to #80508

I noticed bfetch was a dependency on a number of plugins and hadn't been migrated yet... figured I'd take a stab at it.

Feel free to add team pings... it wasn't clear who owns this...?

@clintandrewhall clintandrewhall requested a review from a team as a code owner December 15, 2020 22:04
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Dec 15, 2020
@clintandrewhall clintandrewhall added the release_note:skip Skip the PR/issue when compiling release notes label Dec 15, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 15, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov
Copy link
Contributor

would you mind listing it as a separate TS project and exclude bfetch from the root tsconfig.json as per https://github.com/elastic/kibana/blob/6e8895403a3af429777e806da5e959f1eda8e6aa/docs/developer/best-practices/typescript.asciidoc#implementation

@lizozom
Copy link
Contributor

lizozom commented Jan 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@mshustov
Copy link
Contributor

already migrated in #87294

@clintandrewhall clintandrewhall deleted the tsp-bfetch branch July 9, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov Awaiting requested review from mshustov

@streamich streamich Awaiting requested review from streamich

Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes review v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintandrewhall @kibanamachine @mshustov @lizozom