Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility (#208446) #208487

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ton visibility (elastic#208446)

## Summary

Working on "SIEM Migrations" we needed to be able to have a bigger
height for the ES|QL editor. To achive that we could use
`editorIsInline` prop which extends the height of the editor, though it
would expose "run query" button. The "run query" button does not fit the
the UI of the "SIEM Migrations" feature, so we added the new prop
`hideRunQueryButton` to be able to hide the "run query" button. More
details in
[slack](https://elastic.slack.com/archives/C06RG9MTZMJ/p1737996842482479).

### Screenshot of the inlined ES|QL editor within "SIEM Migrations"
feature

<img width="1281" alt="Screenshot 2025-01-27 at 21 31 24"
src="https://github.com/user-attachments/assets/4b6f1917-c7f0-4a73-9e3b-912257d6d825"
/>

(cherry picked from commit 34092ec)
@kibanamachine kibanamachine merged commit 2c52ca4 into elastic:8.x Jan 28, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / BadArgument component should display message and help output if command is not hidden from help

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 394.7KB 394.7KB +28.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-editor 36 37 +1
esql 50 51 +1
total +2

cc @e40pud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants