[Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation #102306

machadoum · 2021-06-16T08:36:20Z

Migrate Security Solutions explore tab group to deep-link navigation.

It includes

Update navigateToApp and getUrlForApp to provide the deepLinkId
Update Hosts and Network routes to start from /hosts and /network
Add Hosts and Network to side nav menu under "Explore" menu group
Delete Hosts and Network old menu code
Fix broken tests

Checklist

Unit or functional tests were updated or added to match the most common scenarios

x-pack/plugins/security_solution/public/hosts/pages/index.tsx

Bamieh

Telemetry changes LGTM (application usage schema).

x-pack/plugins/security_solution/public/plugin.tsx

x-pack/plugins/security_solution/public/hosts/pages/types.ts

x-pack/plugins/security_solution/public/app/index.tsx

machadoum · 2021-06-17T12:48:49Z

x-pack/plugins/security_solution/public/common/components/navigation/tab_navigation/index.tsx

  const handleClick = useCallback(
    (ev) => {
      ev.preventDefault();
-      if (id in SecurityPageName && pageId == null) {


Internal tab navigation doesn't require all this logic because it only navigates between tabs of a Sub-plugin and not between Sub-plugins.

FYI: @michaelolo24

semd · 2021-06-17T16:57:17Z

x-pack/plugins/security_solution/public/management/components/administration_list_page.tsx

-              urlKey: 'administration',
-              pageId: SecurityPageName.administration,


These urlKey and pageId are not needed anymore? just to understand

Now that SecuritySolutionTabNavigation is only used for SubPlugins internal tabs (Network, Hosts, and Administration), I could delete the logic for handling the navigation between SubPlugins. It includes deleting urlKey and pageId.

urlKey was used for building a new query string for a SubPlugin. since all tabs are inside a subPlugin, the query string is always the same.

pageId was used to determine if the tab link should navigate to a new SubPlugin or an internal tab. Now it always navigates to an internal tab with history.push.

Unfortunately, both tab navigations, Side and Internal, are using the same types. I took a quick look, and modify it would require many changes.

It also simplifies tab_navigation since it only handles plugin internal navigation

x-pack/plugins/security_solution/common/constants.ts

semd

Merging this PR to start integration with other sections. The missing parts will be done in another PR.

kibanamachine · 2021-06-22T18:36:34Z

💚 Build Succeeded

History

💚 Build #132593 succeeded f0f60f8
💔 Build #132440 failed 886990af18aac9da1d0f942104ff9b706112a1f5
💔 Build #132375 failed 54e115b39f27c2a96fd9904be956ae16a2b4cebd
💔 Build #132352 failed e4709ccece8afaf3db44a286de1496fea677a6d7
💔 Build #132027 failed 1eaca2bd48282e350f2bad8857860d1d0ae2ec7c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

…tab group to deep link navigation (elastic#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests

…tab group to deep link navigation (#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests

* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <sergi.massaneda@elastic.co> * Migrate "Investigate" tab group to new side navigation (#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (elastic#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (elastic#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (elastic#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <sergi.massaneda@elastic.co> * Migrate "Investigate" tab group to new side navigation (elastic#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (elastic#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (elastic#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

* [SecuritySolutions] [Navigation] Prepare new routing and migrate overview (#101733) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation (#102306) * Update navigateToApp and getUrlForApp to provide the deepLinkId * Update Hosts and Network routes to start from /hosts and /network * Add Hosts and Network to side nav menu under "Explore" menu group * Delete Hosts and Network old menu code * Fix broken tests * [SecuritySolution] Add detections subplugin to deeplink (#101791) * prepare new routing and migrate overview * init nav deeplink * split detections into rules and alerts * init exception link * init detections * link to rules creation page * link to rules creation page * rename detections to alerts * fix unit tests * fix rules creation page * remove console * fix lint error * fix unit tests * fix unit tests * isolating rules and exceptions page * replace history push with navigateToApp * fix unit test * temporary fix for createCoreStartMock * update cypress * skip failing cypress * skip failing cypress Co-authored-by: semd <sergi.massaneda@elastic.co> * Migrate "Investigate" tab group to new side navigation (#102705) * Migrate "Investigate" tab group to new side navigation It includes: * Timelines * Cases * Quick fix useFormatUrl and HeaderPage navigation * [Security Solutions] Management navigation (#102685) * prepare new routing and migrate overview * test fix and todo comments identified * telemetry using app views * navigation groups implemented * cleaning * export subplugin routes as route props array * breadcrumbs changes and sidenav generation improvements * jest tests for breadcrumbs and navigation changes * retrocompatibility for sections that are not yet migrated to deepLinks * management deepLinks and plugin refactoring * home navigation changes * management navigation migrated to deeplinks * jest tests fixed * header page back link improved and tests fixed * type errors fixes * improve home navigation encapsulation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fix type checking * export header page * fix padding * add redirect routes * unskip detection cypress * fix i18n * fix create your own rules btn * fix cancel button on rules creation page * test fixes * fix breadcrumbs for rules pages * unit test fixes * additional fixes * [Security Solutions] Navigation usage tracker and general changes (#103271) * [Security Solutions] use of currentAppId$ migrated. and some small fixes * unused constants removed * remove unused constant * test fix and types * fix cypress * fix cypress tests * Fix case navTab permission and tests * Revert 'timeline.isOpen' breadcrumb code that was deleted during merge * Fix useInsertTimeline test by removing '/' * change global navigation visible deeplinks * fix /admininstration top level redirect to * fix global search icon, nav order and overview hosts link * update start a new case link * fix rules link in exception list table * unskip cypress tests * update rules link * fix full screen timeline * fixing broken links and administration telemetry split * remove unused comments * remove timeline z-index and cleanup global header component * some minor fixes * add unit tests for detections breadcrumbs * remove case to global/search nav when cases is none * rename test scenario * fix side_panel flyout * fix cases use cases between search/gobal nav * timeline snapshot regenerated and cypres test fixed * rollback management tracking split as it causes unexpected errors on the telemetry component Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

machadoum requested review from angorayc and semd June 16, 2021 08:36

machadoum self-assigned this Jun 16, 2021

machadoum requested review from a team as code owners June 16, 2021 08:36

machadoum commented Jun 16, 2021

View reviewed changes

x-pack/plugins/security_solution/public/hosts/pages/index.tsx Outdated Show resolved Hide resolved

Bamieh approved these changes Jun 16, 2021

View reviewed changes

machadoum commented Jun 16, 2021

View reviewed changes

x-pack/plugins/security_solution/public/plugin.tsx Outdated Show resolved Hide resolved

machadoum commented Jun 16, 2021

View reviewed changes

x-pack/plugins/security_solution/public/hosts/pages/types.ts Outdated Show resolved Hide resolved

machadoum commented Jun 16, 2021

View reviewed changes

x-pack/plugins/security_solution/public/app/index.tsx Outdated Show resolved Hide resolved

machadoum force-pushed the security-navigation-hosts-1101 branch from 71b8286 to f373e68 Compare June 17, 2021 12:08

machadoum requested a review from a team as a code owner June 17, 2021 12:08

machadoum marked this pull request as draft June 17, 2021 12:10

machadoum changed the title ~~Migrate Security Solutions '/hosts' to deep link navigation~~ Migrate Security Solutions 'explore' tab group to deep link navigation Jun 17, 2021

machadoum force-pushed the security-navigation-hosts-1101 branch from 96185ec to 1eaca2b Compare June 17, 2021 12:27

machadoum commented Jun 17, 2021

View reviewed changes

semd reviewed Jun 17, 2021

View reviewed changes

machadoum added 6 commits June 18, 2021 13:06

Migrate Security Solutions '/hosts' to deep link navigation

9fa43f0

Migrate Security Solutions '/hosts/ml-hosts' to deep link navigation

a3c59e1

Move 'Hosts' to explore nav tab group

807c972

Fix telemetry

ad98493

Fix jest unit test

d0e50ee

Fix internal tab_navigation href

656f9e4

It also simplifies tab_navigation since it only handles plugin internal navigation

machadoum force-pushed the security-navigation-hosts-1101 branch from e4709cc to 9811963 Compare June 18, 2021 11:09

machadoum added 3 commits June 18, 2021 13:17

Migrate Security Solutions '/network' to deep link navigation

9f13e80

Fix telemetry

01b0784

Fix unit tests

eb91273

machadoum force-pushed the security-navigation-hosts-1101 branch from 9811963 to 54e115b Compare June 18, 2021 11:17

machadoum changed the title ~~Migrate Security Solutions 'explore' tab group to deep link navigation~~ [Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation Jun 18, 2021

Temporary fix for Side Navigation href

e3a3dd9

machadoum force-pushed the security-navigation-hosts-1101 branch from 54e115b to 886990a Compare June 18, 2021 15:17

Fix internal tab href

f0f60f8

machadoum force-pushed the security-navigation-hosts-1101 branch from 886990a to f0f60f8 Compare June 21, 2021 09:12

machadoum marked this pull request as ready for review June 21, 2021 12:27

machadoum requested review from XavierM and cnasikas June 21, 2021 12:31

XavierM reviewed Jun 21, 2021

View reviewed changes

x-pack/plugins/security_solution/common/constants.ts Show resolved Hide resolved

semd approved these changes Jun 22, 2021

View reviewed changes

machadoum merged commit 796b649 into elastic:security-navigation-1101 Jun 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation #102306

[Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation #102306

machadoum commented Jun 16, 2021 •

edited

Loading

Bamieh left a comment

machadoum Jun 17, 2021 •

edited

Loading

semd Jun 17, 2021 •

edited

Loading

machadoum Jun 18, 2021 •

edited

Loading

semd left a comment

kibanamachine commented Jun 22, 2021

		urlKey: 'administration',
		pageId: SecurityPageName.administration,

[Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation #102306

[Security Solution][Navigation] Migrate Security Solutions 'explore' tab group to deep link navigation #102306

Conversation

machadoum commented Jun 16, 2021 • edited Loading

It includes

Checklist

Bamieh left a comment

Choose a reason for hiding this comment

machadoum Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

semd Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

machadoum Jun 18, 2021 • edited Loading

Choose a reason for hiding this comment

semd left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 22, 2021

💚 Build Succeeded

History

machadoum commented Jun 16, 2021 •

edited

Loading

machadoum Jun 17, 2021 •

edited

Loading

semd Jun 17, 2021 •

edited

Loading

machadoum Jun 18, 2021 •

edited

Loading