Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Color Mapping Nitpicks #191878

Closed
2 tasks
MichaelMarcialis opened this issue Aug 30, 2024 · 1 comment · Fixed by #192242
Closed
2 tasks

[Lens] Color Mapping Nitpicks #191878

MichaelMarcialis opened this issue Aug 30, 2024 · 1 comment · Fixed by #192242
Assignees
@markov00
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

The following are a few nitpick issues regarding the new Len color mapping interface (split off from a previous issue):

  • Change the root-level flyout's color mapping edit icon button to use color="text".

    Image

  • Attempting to click the top or bottom portions above or below the color mapping preview strip doesn't open the second-level color mapping flyout, despite showing a pointer icon on hover. Only clicking directly on the preview strip does it function correctly. Can we correct this so the pointer is only shown on areas that will trigger the second-level flyout?

    CleanShot 2023-10-02 at 13 49 47
@MichaelMarcialis MichaelMarcialis added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 self-assigned this Sep 6, 2024
@markov00 markov00 mentioned this issue Sep 6, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 16, 2024
@markov00
[Lens][ColorMapping] Fix color mapping nitpicks (elastic#192242)
219c15f 
## Summary

Fixed the edit button color.
I've removed completely the `cursor:pointer` and the click
handler/capability over the color band (`EuiColorPaletteDisplay`
component) because this component is not a button and is not keyboard
accessible even with the click handler.
It should be changed in EUI to button to be used correctly.

fix elastic#191878

(cherry picked from commit f3535e9)
kibanamachine referenced this issue Sep 16, 2024
@kibanamachine @markov00
[8.x] [Lens][ColorMapping] Fix color mapping nitpicks (#192242) (#192995
830eada 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens][ColorMapping] Fix color mapping nitpicks
(#192242)](#192242)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2024-09-16T11:30:24Z","message":"[Lens][ColorMapping]
Fix color mapping nitpicks (#192242)\n\n## Summary\r\n\r\nFixed the edit
button color.\r\nI've removed completely the `cursor:pointer` and the
click\r\nhandler/capability over the color band
(`EuiColorPaletteDisplay`\r\ncomponent) because this component is not a
button and is not keyboard\r\naccessible even with the click
handler.\r\nIt should be changed in EUI to button to be used
correctly.\r\n\r\nfix
https://github.com/elastic/kibana/issues/191878","sha":"f3535e9838e675ded589f34d4b0839f1804b21b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Lens][ColorMapping]
Fix color mapping
nitpicks","number":192242,"url":"https://github.com/elastic/kibana/pull/192242","mergeCommit":{"message":"[Lens][ColorMapping]
Fix color mapping nitpicks (#192242)\n\n## Summary\r\n\r\nFixed the edit
button color.\r\nI've removed completely the `cursor:pointer` and the
click\r\nhandler/capability over the color band
(`EuiColorPaletteDisplay`\r\ncomponent) because this component is not a
button and is not keyboard\r\naccessible even with the click
handler.\r\nIt should be changed in EUI to button to be used
correctly.\r\n\r\nfix
https://github.com/elastic/kibana/issues/191878","sha":"f3535e9838e675ded589f34d4b0839f1804b21b4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192242","number":192242,"mergeCommit":{"message":"[Lens][ColorMapping]
Fix color mapping nitpicks (#192242)\n\n## Summary\r\n\r\nFixed the edit
button color.\r\nI've removed completely the `cursor:pointer` and the
click\r\nhandler/capability over the color band
(`EuiColorPaletteDisplay`\r\ncomponent) because this component is not a
button and is not keyboard\r\naccessible even with the click
handler.\r\nIt should be changed in EUI to button to be used
correctly.\r\n\r\nfix
https://github.com/elastic/kibana/issues/191878","sha":"f3535e9838e675ded589f34d4b0839f1804b21b4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens][ColorMapping] Fix color mapping nitpicks markov00/kibana
4 participants
@markov00 @MichaelMarcialis @elasticmachine @teresaalvarezsoler