fix links by adding a line-break after the comment

elastic · Jan 14, 2025 · b7f5f14 · b7f5f14
1 parent ae3f2c5
commit b7f5f14
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/.buildkite/pipeline-utils/github/github.ts b/.buildkite/pipeline-utils/github/github.ts
@@ -136,7 +136,7 @@ export async function upsertComment(
   }
 
   const commentMarker = `<!-- ${KIBANA_COMMENT_SIGIL}:${commentContext} -->`;
-  const body = `${commentMarker}${commentBody}`;
+  const body = `${commentMarker}\n${commentBody}`;
 
   const existingComment = (
     await github.paginate(github.issues.listComments, {

diff --git a/.buildkite/scripts/lifecycle/comment_on_pr.ts b/.buildkite/scripts/lifecycle/comment_on_pr.ts
@@ -42,15 +42,13 @@ export function commentOnPR({
   context?: string;
   clearPrevious: boolean;
 }) {
-  const message = linkify(
-    messageTemplate.replace(/\${([^}]+)}/g, (_, envVar) => {
-      if (ALLOWED_ENV_VARS.includes(envVar)) {
-        return process.env[envVar] || '';
-      } else {
-        return '${' + envVar + '}';
-      }
-    })
-  );
+  const message = messageTemplate.replace(/\${([^}]+)}/g, (_, envVar) => {
+    if (ALLOWED_ENV_VARS.includes(envVar)) {
+      return process.env[envVar] || '';
+    } else {
+      return '${' + envVar + '}';
+    }
+  });
 
   if (context) {
     return upsertComment({ commentBody: message, commentContext: context, clearPrevious });
@@ -59,11 +57,6 @@ export function commentOnPR({
   }
 }
 
-function linkify(text: string) {
-  const linkRegex = /https?:\/\/\S+/g;
-  return text.replaceAll(linkRegex, '[$&]($&)');
-}
-
 if (require.main === module) {
   const args = parseArgs<{
     context?: string;