-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[elasticsearch] Add option to provide custom start/stop hooks #197
[elasticsearch] Add option to provide custom start/stop hooks #197
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
…dd sugested test Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@commercetools.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This looks perfect ⭐️
jenkins test this please |
@Crazybus there is some issue on k8s 1.13, not related to the PR :
|
None of your changes should be affecting the integration tests. The template testing passed though so good enough https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+template-testing/73/. I'll look into the flakiness of the other tests but that's unrelated to your changes. Thank you again for adding this in! |
@Crazybus any updates on when those changes will be released? |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml
PR should fix issue: #190