-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI for monorepo releases #8308
Merged
tkajtoch
merged 11 commits into
elastic:eui-theme/borealis
from
tkajtoch:build/monorepo-releases-setup
Feb 28, 2025
Merged
Add CLI for monorepo releases #8308
tkajtoch
merged 11 commits into
elastic:eui-theme/borealis
from
tkajtoch:build/monorepo-releases-setup
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77a23ff
to
f9fbb27
Compare
mgadewoll
reviewed
Feb 24, 2025
mgadewoll
reviewed
Feb 27, 2025
…pological workspace tree calculation
…paces in topological order
mgadewoll
reviewed
Feb 27, 2025
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @tkajtoch |
mgadewoll
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐈⬛ The changes look good to me and testing the releases locally worked as expected 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/elastic/eui-private/issues/136.
Summary
This PR adds a new release CLI for EUI monorepo. It reuses changelog calculation and versioning logic from the old release script and comes with a bunch more safety checks as well as monorepo workspaces awareness.
QA
gh pr checkout 8308
yarn workspace @elastic/eui-release-cli run build
npm logout
and double check withnpm whoami
docker run -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccio
.yarnrc.yml
yarn npm login
Logging in to http://localhost:4873
test
/test
)yarn npm whoami
packages/eui/changelogs/upcoming
andpackages/eslint-plugin/changelogs/upcoming
and commit them (temporarily so that the release script can proceed with its init checks)yarn release run snapshot --allow-custom
snapshot
release, meaning that it'll publish packages with thesnapshot
tag and will allow a release from non-main
branch.--allow-custom
allows releasing code that's different from what's available upstream@elastic/eui
and@elastic/eslint-plugin-eui
are published to the custom registryyarn npm logout
.yarnrc.yml
git reset --hard