Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Refresh] Provide legacy JSON tokens via EUI #8125

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Nov 8, 2024

Summary

Important

This update is temporary as it's only a workaround while we're working on finding a proper solution to loading the legacy files in Kibana from the new theme package.

This PR adds the legacy JSON files to the eui package.

QA

  • CI passes
  • verify files are available:
    • checkout this PR: gh pr checkout 8125
    • build the eui package locally: yarn build-pack (in /packages/eui)
    • check the built .tgz package content and verify the added JSON files are available in the dist folder

- this is a temporary workaround while we figure out how to convince Kibana load those files from a standalone package
@mgadewoll mgadewoll changed the base branch from main to eui-theme/borealis November 8, 2024 17:53
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mgadewoll mgadewoll marked this pull request as ready for review November 8, 2024 18:25
@mgadewoll mgadewoll requested a review from a team as a code owner November 8, 2024 18:25
@mgadewoll mgadewoll merged commit d208f7b into elastic:eui-theme/borealis Nov 11, 2024
8 checks passed
mgadewoll added a commit to mgadewoll/eui that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants