Do not remove deprecated rowCompressed, but add more documentation …

…around it + remove internal usage
elastic · Nov 13, 2024 · ef2ad65 · ef2ad65
1 parent fd550e0
commit ef2ad65
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/eui/src/components/color_picker/color_picker.tsx b/packages/eui/src/components/color_picker/color_picker.tsx
@@ -456,7 +456,6 @@ export const EuiColorPicker: FunctionComponent<EuiColorPickerProps> = ({
     mode === 'secondaryInput' || secondaryInputDisplay !== 'none';
   const inlineInput = showSecondaryInput && (
     <EuiFormRow
-      display="rowCompressed"
       isInvalid={isInvalid}
       error={isInvalid ? colorErrorMessage : null}
     >

diff --git a/packages/eui/src/components/form/form_row/form_row.styles.ts b/packages/eui/src/components/form/form_row/form_row.styles.ts
@@ -49,8 +49,7 @@ export const euiFormRowStyles = (euiThemeContext: UseEuiTheme) => {
         ${logicalCSS('margin-top', euiTheme.size.base)}
       }
     `,
-    // No difference from the uncompressed row for this current theme AFAICT
-    // TODO: Deprecate prop
+    // No difference from the uncompressed row for the current EUI theme
     get rowCompressed() {
       return this.row;
     },

diff --git a/packages/eui/src/components/form/form_row/form_row.tsx b/packages/eui/src/components/form/form_row/form_row.tsx
@@ -35,7 +35,8 @@ export const DISPLAYS = [
   'center',
   'centerCompressed',
   /**
-   * @deprecated
+   * This currently does not affect styles/appearances
+   * in EUI's present primary theme, but may in the future.
    */
   'rowCompressed',
 ] as const;