[CI] Netty4HttpServerTransportTests testExpectUnsupportedExpectation failing #98869
Assignees
Labels
:Distributed Coordination/Network
Http and internode communication implementations
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test-failure
Triaged test failures from CI
Comments
andreidan
added
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
The actual leak comes from |
|
It apparently reproduces fairly readily with |
|
And I think it's just that we're missing a diff --git a/modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpHeaderValidatorTests.java b/modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpHeaderValidatorTests.java
index 80356e2e371..7267ca0a9b5 100644
--- a/modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpHeaderValidatorTests.java
+++ b/modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpHeaderValidatorTests.java
@@ -632,6 +632,7 @@ public class Netty4HttpHeaderValidatorTests extends ESTestCase {
assertThat(netty4HttpHeaderValidator.getState(), equalTo(WAITING_TO_START));
ByteBuf buf = channel.alloc().buffer();
+ try {
ByteBufUtil.copy(AsciiString.of("test full http request"), buf);
final DefaultFullHttpRequest request = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "/uri", buf);
channel.writeInbound(request);
@@ -658,6 +659,9 @@ public class Netty4HttpHeaderValidatorTests extends ESTestCase {
assertThat(new String(ByteBufUtil.getBytes(throughRequest.content()), StandardCharsets.UTF_8), is("test full http request"));
assertThat(buf.refCnt(), is(1));
assertThat(throughRequest.decoderResult().cause(), nullValue());
+ } finally {
+ buf.release();
+ }
}
public void testFullRequestWithDecoderException() {But that looks like a general problem with all of these tests. |
|
ACK will look into it today. |
|
Raised #99005 |
albertzaharovits
added a commit
that referenced
this issue
Aug 30, 2023
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this issue
Aug 30, 2023
elasticsearchmachine
pushed a commit
that referenced
this issue
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Build scan:
https://gradle-enterprise.elastic.co/s/3uduhyacmbj7o/tests/:modules:transport-netty4:test/org.elasticsearch.http.netty4.Netty4HttpServerTransportTests/testExpectUnsupportedExpectation
Reproduction line:
Applicable branches:
7.17
Reproduces locally?:
Didn't try
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.http.netty4.Netty4HttpServerTransportTests&tests.test=testExpectUnsupportedExpectation
Failure excerpt:
The text was updated successfully, but these errors were encountered: