Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate docs from AsciiDoc to Markdown #2635

Merged
merged 8 commits into from
Feb 27, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Migrate docs from AsciiDoc to Markdown. The preview can be built after #2634 is merged.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a couple typos. I'm excited to see the preview before making any bigger suggestions!

marciw and others added 3 commits February 26, 2025 12:09
Co-authored-by: Josh Mock <josh@joshmock.com>
Co-authored-by: Josh Mock <josh@joshmock.com>
@marciw marciw marked this pull request as ready for review February 26, 2025 22:14
@marciw marciw marked this pull request as draft February 26, 2025 22:15
@marciw marciw marked this pull request as ready for review February 27, 2025 16:11
@marciw
Copy link
Contributor

marciw commented Feb 27, 2025

@marciw
Copy link
Contributor

marciw commented Feb 27, 2025

@JoshMock even though we have some build errors, this is probably ready to go. The preview is here https://docs-v3-preview.elastic.dev/elastic/elasticsearch-js/pull/2635/reference if you want to take a look! (no rush)

... and this bottom part of the nav is a known issue that will be fixed when we build all the docs together instead of just one piece:

Screenshot 2025-02-27 at 11 14 32 AM

@marciw marciw requested a review from JoshMock February 27, 2025 16:22
@marciw
Copy link
Contributor

marciw commented Feb 27, 2025

(to clarify, docs eng says the build errors are fine to overlook, as long as the preview looks ok to you.) 🤘

@JoshMock even though we have some build errors, this is probably ready to go. The preview is here https://docs-v3-preview.elastic.dev/elastic/elasticsearch-js/pull/2635/reference if you want to take a look! (no rush)

... and this bottom part of the nav is a known issue that will be fixed when we build all the docs together instead of just one piece:

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked several pages and everything looks great! 👏

@marciw marciw merged commit 3e5e568 into elastic:main Feb 27, 2025
21 of 22 checks passed
@colleenmcginnis colleenmcginnis deleted the migrate-docs branch February 28, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants