-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate docs from AsciiDoc to Markdown #2635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught a couple typos. I'm excited to see the preview before making any bigger suggestions!
Co-authored-by: Josh Mock <josh@joshmock.com>
Co-authored-by: Josh Mock <josh@joshmock.com>
@JoshMock even though we have some build errors, this is probably ready to go. The preview is here https://docs-v3-preview.elastic.dev/elastic/elasticsearch-js/pull/2635/reference if you want to take a look! (no rush) ... and this bottom part of the nav is a known issue that will be fixed when we build all the docs together instead of just one piece: ![]() |
(to clarify, docs eng says the build errors are fine to overlook, as long as the preview looks ok to you.) 🤘
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot-checked several pages and everything looks great! 👏
Migrate docs from AsciiDoc to Markdown. The preview can be built after #2634 is merged.