Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unit test GitHub action #88

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Clean up unit test GitHub action #88

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15135c6
Clean up unused test config
JoshMock Mar 28, 2024
f15e33d
Stop testing on Node.js v16
JoshMock Mar 28, 2024
a435125
Test license checker on Node.js v18 and v20
JoshMock Mar 28, 2024
707bef5
Upgrade action versions to latest
JoshMock Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 6 additions & 49 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,17 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 19.x, 20.x]
node-version: [18.x, 19.x, 20.x]
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

# workaround for failing tests on Node.js 14.x
# see https://github.com/actions/setup-node/issues/411
- name: Force install specific npm version
run: |
npm install --global npm@8.3.1
npm install --global npm@9.7.1

- name: Install
run: |
npm install
Expand All @@ -49,55 +42,19 @@ jobs:
run: |
npm run test:acceptance

# TODO: migrate to Buildkite, Codecov is no longer used at Elastic
# code-coverage:
# name: Code coverage
# runs-on: ubuntu-latest

# strategy:
# matrix:
# node-version: [18.x]

# steps:
# - uses: actions/checkout@v3

# - name: Use Node.js ${{ matrix.node-version }}
# uses: actions/setup-node@v2
# with:
# node-version: ${{ matrix.node-version }}

# - name: Install
# run: |
# npm install

# - name: Code coverage report
# run: |
# npm run test:coverage-report

# - name: Upload coverage to Codecov
# uses: codecov/codecov-action@v3
# with:
# file: ./coverage.lcov
# fail_ci_if_error: true

# TODO: renabled this as soon as the project is back at 100%
# - name: Code coverage 100%
# run: |
# npm run test:coverage-100

license:
name: License check
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

Expand Down
Loading