Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18](backport #6565) FIPS Build #7078

Open
wants to merge 1 commit into
base: 8.18
Choose a base branch
from
Open

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 28, 2025

What does this PR do?

Adds FIPS env var to magefile to enable FIPS compliant builds using the microsoft/go toolchain.

This PR will not be sufficient to ensure that every artifact made with these changes are compliant, we still need to verify our crypto use.

Why is it important?

FIPS artifacts must be built with compliant toolchains.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None

How to test this PR locally

Assuming microsoft go is available, run FIPS=true mage build:binary


This is an automatic backport of pull request #6565 done by [Mergify](https://mergify.com).

Adds FIPS env var to magefile to enable FIPS compliant
binary builds using the microsoft/go toolchain.

(cherry picked from commit b20efc1)
@mergify mergify bot requested a review from a team as a code owner February 28, 2025 07:23
@mergify mergify bot added the backport label Feb 28, 2025
@mergify mergify bot requested a review from a team as a code owner February 28, 2025 07:23
@mergify mergify bot requested review from pkoutsovasilis and kaanyalti and removed request for a team February 28, 2025 07:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm if this needs to be backported to the 8.18?

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

cc @michel-laterman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants