Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Breaking changes sections in CHANGELOG.next #1408

Merged
merged 7 commits into from
May 12, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented May 11, 2021

Consolidate all breaking changes into the Breaking changes section under Unreleased in CHANGELOG.next.md.

Unreleased, non-breaking changes can continue going under Unreleased underneath the Schema Changes and Tooling and Artifact Changes headers, but Breaking changes will remain underneath Unreleased for the remaining 1.x minors as we introduce breaking changes into the master branch.

Additionally, I updated CONTRIBUTING.md with more details around the ECS repo's branching strategy and changelog conventions.

@ebeahan ebeahan self-assigned this May 11, 2021
@ebeahan ebeahan requested review from kgeller and djptek May 11, 2021 16:25
@ebeahan ebeahan mentioned this pull request May 11, 2021
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit aeab583 into elastic:master May 12, 2021
@ebeahan ebeahan deleted the improve-changelog-guidance branch May 12, 2021 15:20
@ebeahan
Copy link
Member Author

ebeahan commented May 17, 2021

Backports #1413 #1412

rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants