Skip to content

[dr][xmlparser.rb] XMLData - adding dr_active_spells #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2024
Merged

[dr][xmlparser.rb] XMLData - adding dr_active_spells #691

merged 7 commits into from
Oct 31, 2024

Conversation

MahtraDR
Copy link
Contributor

All cleaned up and working now.

@MahtraDR MahtraDR marked this pull request as ready for review October 30, 2024 23:22
mrhoribu
mrhoribu reviewed Oct 30, 2024
View reviewed changes
@mrhoribu mrhoribu changed the title [games][dr] XMLData - adding dr_active_spells [dr][xmlparser.rb] XMLData - adding dr_active_spells Oct 30, 2024
@MahtraDR MahtraDR mentioned this pull request Oct 31, 2024
Merged
mrhoribu
mrhoribu approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mrhoribu mrhoribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrhoribu mrhoribu merged commit 6992d8c into elanthia-online:staging Oct 31, 2024
@MahtraDR MahtraDR deleted the xml_data_dr_active_spells branch October 31, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrhoribu mrhoribu mrhoribu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MahtraDR @mrhoribu