Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on python3.9 #112

Merged
merged 2 commits into from
Dec 25, 2020
Merged

Fix crash on python3.9 #112

merged 2 commits into from
Dec 25, 2020

Conversation

shostyn
Copy link
Contributor

@shostyn shostyn commented Dec 24, 2020

No description provided.

@shostyn
Copy link
Contributor Author

shostyn commented Dec 24, 2020

probably caused by math.hypot changing in python 3.8

@eladyaniv01
Copy link
Owner

eladyaniv01 commented Dec 24, 2020 •
edited
Loading

Okay so this change makes it compatible with python 3.9, but what about 3.8 and 3.7

did you ensure that the previous behavior did not change ?

@eladyaniv01 eladyaniv01 merged commit d0118ee into eladyaniv01:develop Dec 25, 2020
@shostyn shostyn deleted the patch-3 branch December 31, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shostyn @eladyaniv01