Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node-wasm): Switch to bundler target for wasm-pack for manifest v3 #398

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

fl0rek
Copy link
Member

@fl0rek fl0rek commented Sep 27, 2024

No description provided.

@fl0rek fl0rek force-pushed the feat/service-worker-compat branch from 10dc4ea to ef03ea8 Compare September 27, 2024 19:16
@fl0rek fl0rek force-pushed the feat/service-worker-compat branch 2 times, most recently from 989501e to 57cc4cb Compare October 1, 2024 08:05
@fl0rek fl0rek force-pushed the feat/service-worker-compat branch from 57cc4cb to c68d43c Compare October 1, 2024 08:06
@fl0rek fl0rek marked this pull request as ready for review October 1, 2024 08:07
@fl0rek fl0rek changed the title Switch to bundler target for wasm-pack for manifest v3 chore(node-wasm): Switch to bundler target for wasm-pack for manifest v3 Oct 1, 2024
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@zvolin
Copy link
Member

zvolin commented Oct 1, 2024

I once got this when running extension:

2024-10-01T11:41:20.547000064Z ERROR lumina_node_wasm::commands: invalid response, received: InternalPong

Maybe we could increase interval in NodeClient::new to 200ms just in case?

fl0rek and others added 3 commits October 1, 2024 19:08
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@fl0rek fl0rek requested a review from oblique October 2, 2024 07:48
@oblique oblique merged commit 6fee3ed into eigerco:main Oct 3, 2024
6 checks passed
This was referenced Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants