Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node,node-wasm)!: Integrate graceful shutdown in WASM #396

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Sep 25, 2024

No description provided.

@oblique oblique force-pushed the feat/node-wasm-stop branch from 7d5f0e3 to efffb27 Compare September 25, 2024 18:20
@oblique oblique changed the title feat(node-wasm)!: Add stop() in NodeClient feat(node,node-wasm)!: Add stop() in WASM's NodeClient Sep 26, 2024
@oblique oblique changed the title feat(node,node-wasm)!: Add stop() in WASM's NodeClient feat(node,node-wasm)!: Integrate graceful shutdown in WASM Sep 26, 2024
@oblique oblique marked this pull request as ready for review September 26, 2024 12:10
@oblique oblique requested review from fl0rek and zvolin September 26, 2024 12:10
@zvolin zvolin linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here be dragons!

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
@zvolin zvolin merged commit b7b35a6 into eigerco:main Sep 27, 2024
6 checks passed
@oblique oblique deleted the feat/node-wasm-stop branch September 27, 2024 16:04
This was referenced Sep 27, 2024
This was referenced Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement graceful shutdown
3 participants