feat(node): adding agent version #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
reviewed
Sep 13, 2024
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
oblique
approved these changes
Sep 13, 2024
fl0rek
approved these changes
Sep 13, 2024
zvolin
approved these changes
Sep 13, 2024
oblique
approved these changes
Sep 13, 2024
Merged
zvolin
added a commit
to fl0rek/celestia-node-rs
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com> Co-authored-by: Yiannis Marangos <psyberbits@gmail.com> Co-authored-by: zvolin <mac.zwolinski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At ProbeLab we are measuring the Celestia network and producing weekly reports. We would like to include numbers on light nodes, however we noticed that Lumina nodes don't advertise an agent version through the libp2p identify protocol. So we cannot distinguish Lumina nodes, and we would like to include them in our statistics.
I added just the basic user agent, feel free to complete the PR and add more information, such as version number, build etc. For inspiration
celestia-nodeuses the following user agent formatcelestia-node/celestia/light/v0.16.0/6744f64.