Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: Implement graceful shutdown #343

Merged
merged 20 commits into from
Sep 17, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jul 19, 2024

No description provided.

@oblique oblique force-pushed the feat/graceful-shutdown branch 2 times, most recently from c4856f5 to 75fc618 Compare July 20, 2024 22:00
@oblique oblique force-pushed the feat/graceful-shutdown branch 2 times, most recently from 1da70f9 to ff671b1 Compare August 13, 2024 14:05
@oblique oblique force-pushed the feat/graceful-shutdown branch from ff671b1 to 5a7d254 Compare August 13, 2024 14:15
@oblique oblique requested review from zvolin and fl0rek August 13, 2024 14:51
@oblique oblique changed the title feat(node): Implement graceful shutdown feat(node)!: Implement graceful shutdown Sep 10, 2024
@oblique oblique marked this pull request as ready for review September 10, 2024 11:37
oblique and others added 2 commits September 12, 2024 11:55
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks solid 🦾

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fl0rek fl0rek merged commit 6aa1268 into eigerco:main Sep 17, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Sep 13, 2024
@oblique oblique deleted the feat/graceful-shutdown branch September 17, 2024 14:33
zvolin pushed a commit to fl0rek/celestia-node-rs that referenced this pull request Sep 20, 2024
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants