Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added title prop for Button #87

Merged
merged 1 commit into from
Jun 24, 2024
Merged

added title prop for Button #87

merged 1 commit into from
Jun 24, 2024

Conversation

Swathi-eGov
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Jun 24, 2024

Walkthrough

The recent updates introduce new features to the react/ui-components library. Specifically, a title prop was added to the Button component, and a new ViewMore button was incorporated into the Timeline Molecule. These enhancements provide additional functionality and customization options for developers using these components.

Changes

File Path Change Summary
react/ui-components/CHANGELOG.md Documented the introduction of the new Title prop for Button and the ViewMore button for Timeline Molecule.
react/ui-components/src/atoms/Button.js Added a new title prop to the Button component with a default value of an empty string.
react/ui-components/src/atoms/stories/Button.stories.js Added the title property to the storybook controls configuration and the commonArgs object.

Sequence Diagram(s)

sequenceDiagram
    participant Developer as Developer
    participant UI as Button Component
    participant DOM as DOM

    Developer->>UI: Passes {title: "Submit"}
    UI->>DOM: Render button with title attribute "Submit"
    Note right of DOM: Button rendered with a tooltip<br> on hover due to title attribute
Loading

Poem

In the gardens of the UI so bright,
A button gained a name tonight.
And 'ViewMore' on the timeline's track,
For stories that never lack. 🌟
With changes clear and simple,
Our code now has more dimple. 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf10937 and 9e8a37a.

Files ignored due to path filters (5)
  • react/modules/Project/package.json is excluded by !**/*.json
  • react/modules/core/package.json is excluded by !**/*.json
  • react/modules/sample/package.json is excluded by !**/*.json
  • react/package.json is excluded by !**/*.json
  • react/ui-components/package.json is excluded by !**/*.json
Files selected for processing (3)
  • react/ui-components/CHANGELOG.md (1 hunks)
  • react/ui-components/src/atoms/Button.js (1 hunks)
  • react/ui-components/src/atoms/stories/Button.stories.js (2 hunks)
Files skipped from review due to trivial changes (1)
  • react/ui-components/src/atoms/stories/Button.stories.js
Additional context used
Biome
react/ui-components/src/atoms/Button.js

[error] 45-48: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

LanguageTool
react/ui-components/CHANGELOG.md

[style] ~44-~44: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ent. - Added Info Button Component. - Added Panels Component. - Added Popup Compon...


[style] ~45-~45: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Panels Component. - Added Popup Component With Two Variants defua...


[style] ~46-~46: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...With Two Variants defualt and alert. - Added RemoveableTag Component. - Added Stepp...


[style] ~47-~47: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t. - Added RemoveableTag Component. - Added Stepper Component. - Added TextBlock Co...


[style] ~48-~48: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Stepper Component. - Added TextBlock Component. - Added Timeline C...


[style] ~49-~49: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...mponent. - Added TextBlock Component. - Added Timeline Component. - Added Uploader Co...


[style] ~50-~50: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Timeline Component. - Added Uploader Component With Three Varinats ...


[style] ~51-~51: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...loadFile,UploadPopup and UploadImage. - Added PanelCard Molecule. ### Enhancements ...


[style] ~57-~57: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t Styles and Added SelectAll Option. - Updated InfoCard Component Styles. - Added Ani...


[uncategorized] ~59-~59: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...Toast. - Added new prop named type for Toast replacing the separate props for info...


[duplication] ~180-~180: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...mes ## [0.0.1-beta.4] - YYYY-MM-DD ### Fixed - Fixed some date issues ## [0.0.1] - 2024-03...

Markdownlint
react/ui-components/CHANGELOG.md

13-13: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


17-17: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


21-21: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


42-42: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


43-43: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


44-44: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


45-45: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


46-46: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


53-53: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


55-55: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


56-56: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


57-57: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


58-58: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


59-59: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


60-60: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


93-93: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


97-97: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


114-114: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


115-115: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


119-119: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


128-128: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


129-129: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


169-169: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


181-181: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


185-185: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


186-186: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


187-187: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


188-188: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


189-189: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces


7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


16-16: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


19-19: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


20-20: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


20-20: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


23-23: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


24-24: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


24-24: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


27-27: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


28-28: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


28-28: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


32-32: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


33-33: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


33-33: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


37-37: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


63-63: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


64-64: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


64-64: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


67-67: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


68-68: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


71-71: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


72-72: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


72-72: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


75-75: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


76-76: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


76-76: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


79-79: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


80-80: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


80-80: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


84-84: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


84-84: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


88-88: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


88-88: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


91-91: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


92-92: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


92-92: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


95-95: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


96-96: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


96-96: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


100-100: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


101-101: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


101-101: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


104-104: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


105-105: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


105-105: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


108-108: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


109-109: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


109-109: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


112-112: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


113-113: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


113-113: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


117-117: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


118-118: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


118-118: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


122-122: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


123-123: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


123-123: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


126-126: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


127-127: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


127-127: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


131-131: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


132-132: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


132-132: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


135-135: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


136-136: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


136-136: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


139-139: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


140-140: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


140-140: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


143-143: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


144-144: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


144-144: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


147-147: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


148-148: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


148-148: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


151-151: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


152-152: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


152-152: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


155-155: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


156-156: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


156-156: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


159-159: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


160-160: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


160-160: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


163-163: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


164-164: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


164-164: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


167-167: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


168-168: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


168-168: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


171-171: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


172-172: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


172-172: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


175-175: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


176-176: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


176-176: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


179-179: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


180-180: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


183-183: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


184-184: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


184-184: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


17-17: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


21-21: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


25-25: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


29-29: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


34-34: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


38-38: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


65-65: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


73-73: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


77-77: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


81-81: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


85-85: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


89-89: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


93-93: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


97-97: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


102-102: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


106-106: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


110-110: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


114-114: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


119-119: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


124-124: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


128-128: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


133-133: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


137-137: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


141-141: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


145-145: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


149-149: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


153-153: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


157-157: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


161-161: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


165-165: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


169-169: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


173-173: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


177-177: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


181-181: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


185-185: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


189-189: null (MD047, single-trailing-newline)
Files should end with a single newline character

Additional comments not posted (2)
react/ui-components/src/atoms/Button.js (1)

Line range hint 45-48: Remove unnecessary else clause.

The else clause is redundant after the previous branches which already return early. Simplifying this will improve the readability and maintainability of the code.
[REFACTOR_SUGGESTion]

    } else if (props.size === "small") {
        width = "0.875rem";
        height = "0.875rem";
-   }else{
-     width = "1.5rem";
-     height ="1.5rem";
    }
react/ui-components/CHANGELOG.md (1)

7-10: Document the new feature effectively.

The changelog entry for the new title prop in the Button component is clear and follows the established format. This is crucial for tracking changes and features effectively.

Tools
Markdownlint

7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines

@jagankumar-egov jagankumar-egov merged commit 1e775c0 into develop Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants