Timeline Molecule #86
Conversation
WalkthroughThis update brings several enhancements to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
react/css/package.jsonis excluded by!**/*.jsonreact/modules/Project/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.json
Files selected for processing (11)
- react/css/CHANGELOG.md (1 hunks)
- react/css/src/digitv2/components/breadcrumbV2.scss (1 hunks)
- react/css/src/digitv2/components/timelineV2.scss (2 hunks)
- react/css/src/digitv2/index.scss (1 hunks)
- react/example/public/index.html (1 hunks)
- react/ui-components/CHANGELOG.md (1 hunks)
- react/ui-components/src/atoms/BreadCrumb.js (2 hunks)
- react/ui-components/src/atoms/Timeline.js (2 hunks)
- react/ui-components/src/atoms/stories/BreadCrumb.stories.js (1 hunks)
- react/ui-components/src/molecules/TimelineMolecule.js (1 hunks)
- react/ui-components/src/molecules/stories/TimelineMolecule.stories.js (5 hunks)
Files skipped from review due to trivial changes (2)
- react/css/src/digitv2/index.scss
- react/example/public/index.html
Additional context used
LanguageTool
react/css/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...log ## [0.0.2-beta.6] - 2024-06-24 ### Added - Added ViewMore button for timeline molecule ...
[duplication] ~8-~8: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...ule ## [0.0.2-beta.5] - 2024-06-19 ### Added - Added BreadCrumb css ## [0.0.2-beta.4] - 202...
[duplication] ~12-~12: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...css ## [0.0.2-beta.4] - 2024-06-17 ### Added - Added Timeline Molecule related css ## [0.0....
[style] ~37-~37: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ent. - Added Info Button Component. - Added Panels Component. - Added Popup Compon...
[style] ~38-~38: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Panels Component. - Added Popup Component With Two Variants defua...
[uncategorized] ~38-~38: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...nent. - Added Popup Component With Two Variants defualt and alert. - Added RemoveableT...
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...With Two Variants defualt and alert. - Added RemoveableTag Component. - Added Stepp...
[style] ~40-~40: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t. - Added RemoveableTag Component. - Added Stepper Component. - Added TextBlock Co...
[style] ~41-~41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Stepper Component. - Added TextBlock Component. - Added Timeline C...
[style] ~42-~42: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...mponent. - Added TextBlock Component. - Added Timeline Component. - Added Uploader Co...
[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Timeline Component. - Added Uploader Component With Three Varinats ...
[style] ~44-~44: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...loadFile,UploadPopup and UploadImage. - Added PanelCard Molecule. ### Enhancements ...
[style] ~50-~50: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t Styles and Added SelectAll Option. - Updated InfoCard Component Styles. - Added Ani...
[uncategorized] ~52-~52: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...Toast. - Added new prop named type for Toast replacing the separate props forinfo...react/ui-components/CHANGELOG.md
[style] ~40-~40: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ent. - Added Info Button Component. - Added Panels Component. - Added Popup Compon...
[style] ~41-~41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Panels Component. - Added Popup Component With Two Variants defua...
[style] ~42-~42: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...With Two Variants defualt and alert. - Added RemoveableTag Component. - Added Stepp...
[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t. - Added RemoveableTag Component. - Added Stepper Component. - Added TextBlock Co...
[style] ~44-~44: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Stepper Component. - Added TextBlock Component. - Added Timeline C...
[style] ~45-~45: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...mponent. - Added TextBlock Component. - Added Timeline Component. - Added Uploader Co...
[style] ~46-~46: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Timeline Component. - Added Uploader Component With Three Varinats ...
[style] ~47-~47: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...loadFile,UploadPopup and UploadImage. - Added PanelCard Molecule. ### Enhancements ...
[style] ~53-~53: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t Styles and Added SelectAll Option. - Updated InfoCard Component Styles. - Added Ani...
[uncategorized] ~55-~55: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...Toast. - Added new prop named type for Toast replacing the separate props forinfo...
[duplication] ~176-~176: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...mes ## [0.0.1-beta.4] - YYYY-MM-DD ### Fixed - Fixed some date issues ## [0.0.1] - 2024-03...
Markdownlint
react/css/CHANGELOG.md
17-17: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
23-23: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
35-35: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
36-36: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
37-37: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
38-38: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
39-39: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
46-46: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
48-48: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
49-49: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
50-50: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
51-51: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
52-52: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
53-53: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
20-20: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
29-29: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
3-3: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
21-21: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
25-25: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
26-26: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
26-26: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
30-30: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
56-56: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
5-5: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
17-17: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
27-27: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
31-31: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
57-57: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
77-77: null (MD047, single-trailing-newline)
Files should end with a single newline characterreact/ui-components/CHANGELOG.md
9-9: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
13-13: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
17-17: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
38-38: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
39-39: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
40-40: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
41-41: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
42-42: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
49-49: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
51-51: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
52-52: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
53-53: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
54-54: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
55-55: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
56-56: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
89-89: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
93-93: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
110-110: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
111-111: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
115-115: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
124-124: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
125-125: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
165-165: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
177-177: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
181-181: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
182-182: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
183-183: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
184-184: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
185-185: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
19-19: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
20-20: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
20-20: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
23-23: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
24-24: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
24-24: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
29-29: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
29-29: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
33-33: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
59-59: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
63-63: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
64-64: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
64-64: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
67-67: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
71-71: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
72-72: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
72-72: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
75-75: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
76-76: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
76-76: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
79-79: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
80-80: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
80-80: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
84-84: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
84-84: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
88-88: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
88-88: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
91-91: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
92-92: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
92-92: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
96-96: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
97-97: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
97-97: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
100-100: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
101-101: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
101-101: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
104-104: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
108-108: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
109-109: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
109-109: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
113-113: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
114-114: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
114-114: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
118-118: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
122-122: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
123-123: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
123-123: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
127-127: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
131-131: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
135-135: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
136-136: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
136-136: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
139-139: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
140-140: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
140-140: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
143-143: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
144-144: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
144-144: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
147-147: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
148-148: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
148-148: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
151-151: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
152-152: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
152-152: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
155-155: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
156-156: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
156-156: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
159-159: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
160-160: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
160-160: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
163-163: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
164-164: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
164-164: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
167-167: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
171-171: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
175-175: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
176-176: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
176-176: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
179-179: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
17-17: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
21-21: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
25-25: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
30-30: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
34-34: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
61-61: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
65-65: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
73-73: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
77-77: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
81-81: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
85-85: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
89-89: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
93-93: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
98-98: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
102-102: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
106-106: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
110-110: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
115-115: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
120-120: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
124-124: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
129-129: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
133-133: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
137-137: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
141-141: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
145-145: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
149-149: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
153-153: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
157-157: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
161-161: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
165-165: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
169-169: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
173-173: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
177-177: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
181-181: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
185-185: null (MD047, single-trailing-newline)
Files should end with a single newline character
Biome
react/ui-components/src/atoms/BreadCrumb.js
[error] 7-7: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)
If it short-circuits with 'undefined' the evaluation will throw TypeError here:
[error] 46-46: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
[error] 57-63: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
react/ui-components/src/atoms/Timeline.js
[error] 121-121: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
[error] 122-122: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or resetreact/ui-components/src/molecules/stories/TimelineMolecule.stories.js
[error] 28-28: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
[error] 64-69: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
[error] 70-76: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
Additional comments not posted (16)
react/css/src/digitv2/components/breadcrumbV2.scss (1)
1-57: Review of breadcrumbV2.scssThe CSS styles are well-organized and make good use of the design system's theming capabilities. The use of
theme()for spacing and colors ensures consistency across the application. However, consider adding comments to complex selectors or properties for better maintainability.react/css/CHANGELOG.md (1)
Line range hint
1-57: Review of CHANGELOG.mdThe changelog entries are clear and provide a good historical record of changes. Ensure that the formatting is consistent with markdown standards, such as adding spaces after list markers and ensuring proper indentation.
Tools
LanguageTool
[duplication] ~4-~4: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...log ## [0.0.2-beta.6] - 2024-06-24 ### Added - Added ViewMore button for timeline molecule ...
[duplication] ~8-~8: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...ule ## [0.0.2-beta.5] - 2024-06-19 ### Added - Added BreadCrumb css ## [0.0.2-beta.4] - 202...
[duplication] ~12-~12: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...css ## [0.0.2-beta.4] - 2024-06-17 ### Added - Added Timeline Molecule related css ## [0.0....Markdownlint
3-3: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
5-5: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank linesreact/css/src/digitv2/components/timelineV2.scss (1)
Line range hint
1-159: Review of timelineV2.scssThe CSS styles for the timeline components are well-structured and make efficient use of the design system's theming capabilities. The media queries for responsive design are appropriately placed. Consider adding comments to complex selectors or properties for better maintainability, especially for the
.timeline-circlevariants.react/ui-components/src/atoms/BreadCrumb.js (3)
1-1: Update imports to include hooks.Importing
useStateanduseEffectfromreactis appropriate for managing state and side effects in this functional component.
26-28: Implement toggle functionality for breadcrumb expansion.The
handleCrumbClickfunction correctly toggles theexpandedstate, which controls the display of breadcrumbs. This is a simple and effective way to handle user interactions.
94-98: Define prop types for new properties.Defining
PropTypesfor the newly added properties ensures that the component usage is predictable and less error-prone.react/ui-components/src/atoms/stories/BreadCrumb.stories.js (2)
9-34: Enhance storybook with control configurations.The addition of
argTypeswith detailed controls for each prop enhances the interactivity and testing capabilities within Storybook. This is a significant improvement for testing component behavior dynamically.
43-186: Implement various breadcrumb configurations for Storybook.The stories cover a wide range of scenarios, including default settings, icons, custom separators, and collapsed views. These stories will be very useful for visual testing of the
BreadCrumbcomponent.react/ui-components/src/atoms/Timeline.js (2)
16-17: Addition of new props to handle timeline steps.The introduction of
isLastStepandisNextActiveStepallows for more granular control over the styling and behavior of timeline elements based on their state.
80-80: Conditional rendering based on new props.The logic to conditionally render the connector line based on
isLastStepandisNextActiveStepis a smart way to handle dynamic styles. However, ensure accessibility for interactive elements.+ onKeyUp={(event) => { if (event.key === "Enter") toggleDetails(); }} + type="button"Likely invalid or redundant comment.
react/ui-components/CHANGELOG.md (1)
7-14: Document new features and components in CHANGELOG.Properly documenting the addition of new features and components such as the
ViewMorebutton andBreadCrumbcomponent helps in tracking changes over versions. Ensure consistent formatting and spacing in markdown files.Tools
Markdownlint
9-9: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
13-13: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank linesreact/ui-components/src/molecules/stories/TimelineMolecule.stories.js (5)
9-12: Update argTypes to include new propertiesThe addition of
initialVisibleCountandviewMoreLabeltoargTypesallows for better control and testing of theTimelineMoleculecomponent. This is a good use of Storybook's capabilities to enhance testing and documentation.
82-84: Ensure consistency in Timeline component usageThe
Timelinecomponents within theDefaultstory are configured consistently, which is good for maintaining a uniform look and feel across different timeline steps.Also applies to: 88-90, 100-102, 106-108
154-196: Review visibility control and variant consistencyThe
WithVisbileCountstory demonstrates how visibility control can be managed using theinitialVisibleCountproperty, which is a good practice for handling large sets of data or UI elements. The consistent use ofvariantandshowConnectorproperties across different timeline steps ensures a uniform appearance.
201-244: Implement view more/less functionality effectivelyThe
WithVisbileCountAndViewMoreLabelstory adds functionality for expanding or collapsing the timeline, which enhances user interaction and accessibility. The use ofviewMoreLabelandviewLessLabelprops is a good practice for providing clear user instructions.
117-119: Add missing key properties to elements in iterableThe additional elements passed to the
Timelinecomponent in theWithAdditionalElementsstory are missing thekeyproperty. This is important for performance and correct re-rendering behavior in React.+ <div key="1">...</div>, + <img key="2" src="..." alt="Additional Element 2" />, + <img key="3" src="..." alt="Additional Element 3" />, + <img key="4" src="..." alt="Additional Element 4" />, + <img key="5" src="..." alt="Additional Element 5" />, + <img key="6" src="..." alt="Additional Element 6" />, + <img key="7" src="..." alt="Additional Element 7" />, + <img key="8" src="..." alt="Additional Element 8" />,Also applies to: 124-126, 138-150
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
react/ui-components/src/molecules/stories/TimelineMolecule.stories.js (1)
Line range hint
28-28: Missing key property in iterable elements.Several elements within the
additionalElementsarray are missing thekeyprop. This is crucial in React for optimizing render performance and should be added.+ <div key="1">...</div> + <img key="2" ... /> + <img key="3" ... /> + <img key="4" ... /> + <img key="5" ... /> + <img key="6" ... /> + <img key="7" ... /> + <img key="8" ... />Also applies to: 64-69, 70-76
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
react/css/package.jsonis excluded by!**/*.jsonreact/modules/Project/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.json
Files selected for processing (7)
- react/css/CHANGELOG.md (1 hunks)
- react/css/src/digitv2/components/timelineV2.scss (2 hunks)
- react/example/public/index.html (1 hunks)
- react/ui-components/CHANGELOG.md (1 hunks)
- react/ui-components/src/atoms/Timeline.js (2 hunks)
- react/ui-components/src/molecules/TimelineMolecule.js (1 hunks)
- react/ui-components/src/molecules/stories/TimelineMolecule.stories.js (5 hunks)
Files not reviewed due to errors (1)
- react/css/CHANGELOG.md (no review received)
Files skipped from review due to trivial changes (1)
- react/example/public/index.html
Additional context used
LanguageTool
react/css/CHANGELOG.md
[duplication] ~4-~4: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...log ## [0.0.2-beta.6] - 2024-06-24 ### Added - Added ViewMore button for timeline molecule ...
[duplication] ~8-~8: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...ule ## [0.0.2-beta.5] - 2024-06-19 ### Added - Added BreadCrumb css ## [0.0.2-beta.4] - 202...
[duplication] ~12-~12: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...css ## [0.0.2-beta.4] - 2024-06-17 ### Added - Added Timeline Molecule related css ## [0.0....
[style] ~37-~37: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ent. - Added Info Button Component. - Added Panels Component. - Added Popup Compon...
[style] ~38-~38: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Panels Component. - Added Popup Component With Two Variants defua...
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...With Two Variants defualt and alert. - Added RemoveableTag Component. - Added Stepp...
[style] ~40-~40: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t. - Added RemoveableTag Component. - Added Stepper Component. - Added TextBlock Co...
[style] ~41-~41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Stepper Component. - Added TextBlock Component. - Added Timeline C...
[style] ~42-~42: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...mponent. - Added TextBlock Component. - Added Timeline Component. - Added Uploader Co...
[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Timeline Component. - Added Uploader Component With Three Varinats ...
[style] ~44-~44: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...loadFile,UploadPopup and UploadImage. - Added PanelCard Molecule. ### Enhancements ...
[style] ~50-~50: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t Styles and Added SelectAll Option. - Updated InfoCard Component Styles. - Added Ani...
[uncategorized] ~52-~52: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...Toast. - Added new prop named type for Toast replacing the separate props forinfo...react/ui-components/CHANGELOG.md
[style] ~40-~40: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ent. - Added Info Button Component. - Added Panels Component. - Added Popup Compon...
[style] ~41-~41: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Panels Component. - Added Popup Component With Two Variants defua...
[uncategorized] ~41-~41: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...nent. - Added Popup Component With Two Variants defualt and alert. - Added RemoveableT...
[style] ~42-~42: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...With Two Variants defualt and alert. - Added RemoveableTag Component. - Added Stepp...
[style] ~43-~43: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t. - Added RemoveableTag Component. - Added Stepper Component. - Added TextBlock Co...
[style] ~44-~44: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Stepper Component. - Added TextBlock Component. - Added Timeline C...
[style] ~45-~45: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...mponent. - Added TextBlock Component. - Added Timeline Component. - Added Uploader Co...
[style] ~46-~46: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...omponent. - Added Timeline Component. - Added Uploader Component With Three Varinats ...
[style] ~47-~47: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...loadFile,UploadPopup and UploadImage. - Added PanelCard Molecule. ### Enhancements ...
[style] ~53-~53: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t Styles and Added SelectAll Option. - Updated InfoCard Component Styles. - Added Ani...
[uncategorized] ~55-~55: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...Toast. - Added new prop named type for Toast replacing the separate props forinfo...
[duplication] ~176-~176: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...mes ## [0.0.1-beta.4] - YYYY-MM-DD ### Fixed - Fixed some date issues ## [0.0.1] - 2024-03...
Markdownlint
react/css/CHANGELOG.md
17-17: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
23-23: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
35-35: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
36-36: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
37-37: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
38-38: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
39-39: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
46-46: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
48-48: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
49-49: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
50-50: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
51-51: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
52-52: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
53-53: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
20-20: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
29-29: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
3-3: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
4-4: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
21-21: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
25-25: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
26-26: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
26-26: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
30-30: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
56-56: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
5-5: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
17-17: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
27-27: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
31-31: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
57-57: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
77-77: null (MD047, single-trailing-newline)
Files should end with a single newline characterreact/ui-components/CHANGELOG.md
9-9: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
13-13: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
17-17: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
38-38: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
39-39: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
40-40: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
41-41: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
42-42: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
49-49: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
51-51: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
52-52: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
53-53: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
54-54: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
55-55: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
56-56: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
89-89: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
93-93: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
110-110: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
111-111: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
115-115: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
124-124: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
125-125: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
165-165: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
177-177: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
181-181: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
182-182: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
183-183: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
184-184: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
185-185: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
12-12: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
15-15: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
16-16: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
19-19: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
20-20: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
20-20: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
23-23: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
24-24: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
24-24: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
29-29: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
29-29: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
33-33: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
59-59: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
63-63: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
64-64: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
64-64: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
67-67: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
71-71: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
72-72: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
72-72: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
75-75: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
76-76: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
76-76: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
79-79: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
80-80: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
80-80: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
84-84: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
84-84: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
88-88: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
88-88: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
91-91: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
92-92: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
92-92: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
96-96: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
97-97: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
97-97: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
100-100: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
101-101: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
101-101: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
104-104: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
108-108: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
109-109: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
109-109: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
113-113: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
114-114: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
114-114: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
118-118: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
122-122: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
123-123: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
123-123: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
127-127: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
131-131: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
135-135: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
136-136: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
136-136: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
139-139: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
140-140: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
140-140: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
143-143: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
144-144: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
144-144: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
147-147: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
148-148: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
148-148: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
151-151: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
152-152: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
152-152: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
155-155: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
156-156: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
156-156: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
159-159: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
160-160: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
160-160: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
163-163: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
164-164: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
164-164: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
167-167: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
171-171: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
175-175: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
176-176: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
176-176: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
179-179: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
13-13: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
17-17: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
21-21: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
25-25: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
30-30: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
34-34: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
61-61: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
65-65: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
73-73: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
77-77: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
81-81: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
85-85: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
89-89: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
93-93: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
98-98: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
102-102: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
106-106: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
110-110: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
115-115: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
120-120: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
124-124: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
129-129: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
133-133: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
137-137: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
141-141: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
145-145: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
149-149: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
153-153: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
157-157: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
161-161: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
165-165: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
169-169: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
173-173: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
177-177: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
181-181: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
185-185: null (MD047, single-trailing-newline)
Files should end with a single newline character
Biome
react/ui-components/src/atoms/Timeline.js
[error] 121-121: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
[error] 122-122: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or resetreact/ui-components/src/molecules/stories/TimelineMolecule.stories.js
[error] 28-28: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
[error] 64-69: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
[error] 70-76: Missing key property for this element in iterable. (lint/correctness/useJsxKeyInIterable)
The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.
Additional comments not posted (7)
react/css/src/digitv2/components/timelineV2.scss (2)
153-159: Ensure consistency in utility class usage.The
.digit-timeline-moleculeand.view-more-containerclasses apply maximum height and margin-top respectively. Verify that these styles are consistent with the rest of the design system and do not introduce any unexpected layout shifts.Verification successful
Ensure consistency in utility class usage.
The
.digit-timeline-moleculeclass uses the@apply max-h-fullutility class, which is consistent with the design system as it is applied similarly in other components. The.view-more-containerclass sets the margin-top using a theme variable, which is a common practice in the codebase. No unexpected layout shifts or inconsistencies were found.
.digit-timeline-moleculeuses the@apply max-h-fullutility class, consistent with other components..view-more-containersets margin-top using a theme variable, aligning with the design system.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent usage of utility classes across the project. # Test: Search for similar styles in other components. rg --type css "@apply max-h-full" --files-with-matches | xargs catLength of output: 3305
23-24: Review border styles for timeline states.The CSS rules for
.inprogressand.nextActiveStepuse the same border color but different styles (dashedanddotted). Ensure this is intentional and consistent with the design requirements.Also applies to: 28-29
react/ui-components/src/atoms/Timeline.js (1)
16-17: Ensure consistent prop handling and rendering logic.The
isLastStepandisNextActiveStepprops are used to conditionally render elements. Verify that these props are being used consistently and correctly throughout the component.Also applies to: 80-80
Verification successful
Prop usage is consistent and correct.
The props
isLastStepandisNextActiveStepare used correctly and consistently within theTimelinecomponent to conditionally render elements.
isLastStepis used to determine if the connector line should be rendered.isNextActiveStepis used to add a class to the connector line.Both props are handled appropriately in the component.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistent use of `isLastStep` and `isNextActiveStep` props. # Test: Search for prop usage in component tests. rg --type js "isLastStep|isNextActiveStep" --files-with-matches | xargs catLength of output: 6469
react/ui-components/CHANGELOG.md (2)
7-9: Well-documented changelog entry for the ViewMore button.The changelog correctly notes the addition of the ViewMore button for the Timeline Molecule under version
0.0.2-beta.7. This helps in tracking feature additions effectively.Tools
Markdownlint
9-9: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
7-7: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
10-10: Changelog entry for BreadCrumb Component is clear.The addition of the BreadCrumb Component is well-documented under version
0.0.2-beta.6. This entry is crucial for understanding the evolution of UI components in the project.react/ui-components/src/molecules/stories/TimelineMolecule.stories.js (2)
9-12: Properly defined argTypes for Storybook.The addition of
initialVisibleCountandviewMoreLabeltoargTypesis a good practice. It enhances the configurability and testability of the component in Storybook.
82-84: Consistent use of the Timeline component.All instances of the
Timelinecomponent within various stories use consistent properties likelabel,subElements,variant, andshowConnector. This consistency is crucial for maintaining uniform behavior across different stories.
[APROVED]Also applies to: 88-90, 100-102, 106-108, 117-119, 124-126, 138-140, 145-147
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- react/ui-components/src/molecules/TimelineMolecule.js (1 hunks)
Additional comments not posted (2)
react/ui-components/src/molecules/TimelineMolecule.js (2)
1-2: Review of import statements.The import of
Childrenfromreactand components from../atomsappears appropriate for the operations performed in this file.
18-65: Ensure proper memoization and state management.The use of
useStateanduseMemofor managing states and memoizing sorted children is correctly implemented. Consider usinguseCallbackfortoggleViewMoreItemsto avoid unnecessary re-renders.
[REFACTOR_SUGGESTion]- const toggleViewMoreItems = () => { + const toggleViewMoreItems = useCallback(() => { setIsExpanded(prev => !prev); setVisibleCount(isExpanded ? initialVisibleCount : sortedChildren.length); - }; + }, [isExpanded, initialVisibleCount, sortedChildren.length]);
| const sortTimelines = (children) => { | ||
| const variantsOrder = { | ||
| upcoming: 1, | ||
| inprogress: 2, | ||
| completed: 3, | ||
| }; | ||
|
|
||
| return Children.toArray(children).sort((a, b) => { | ||
| const variantA = variantsOrder[a.props.variant] || 4; | ||
| const variantB = variantsOrder[b.props.variant] || 4; | ||
| return variantA - variantB; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Optimize the sortTimelines function.
The function efficiently sorts the children based on predefined variant orders. However, consider handling the case where variant prop might be undefined to avoid unexpected behaviors.
- const variantA = variantsOrder[a.props.variant] || 4;
- const variantB = variantsOrder[b.props.variant] || 4;
+ const variantA = a.props.variant ? variantsOrder[a.props.variant] : 4;
+ const variantB = b.props.variant ? variantsOrder[b.props.variant] : 4;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const sortTimelines = (children) => { | |
| const variantsOrder = { | |
| upcoming: 1, | |
| inprogress: 2, | |
| completed: 3, | |
| }; | |
| return Children.toArray(children).sort((a, b) => { | |
| const variantA = variantsOrder[a.props.variant] || 4; | |
| const variantB = variantsOrder[b.props.variant] || 4; | |
| return variantA - variantB; | |
| }); | |
| }; | |
| const sortTimelines = (children) => { | |
| const variantsOrder = { | |
| upcoming: 1, | |
| inprogress: 2, | |
| completed: 3, | |
| }; | |
| return Children.toArray(children).sort((a, b) => { | |
| const variantA = a.props.variant ? variantsOrder[a.props.variant] : 4; | |
| const variantB = b.props.variant ? variantsOrder[b.props.variant] : 4; | |
| return variantA - variantB; | |
| }); | |
| }; |
| const visibleChildren = sortedChildren.slice(0, visibleCount); | ||
|
|
||
|
|
||
| const TimelineMolecule = ({ children }) => { | ||
| return ( | ||
| <div className="digit-timeline-molecule"> | ||
| {Children.map(children, (child, index) => ( | ||
| <Timeline {...child.props} isLastStep={index === Children.count(children) - 1} /> | ||
| {Children.map(visibleChildren, (child, index) => ( | ||
| <Timeline | ||
| {...child.props} | ||
| isLastStep={index === Children.count(visibleChildren) - 1} | ||
| isNextActiveStep={currentActiveStep - 1 === index} | ||
| /> | ||
| ))} | ||
| {initialVisibleCount && ( | ||
| <div className="view-more-container"> | ||
| <Button | ||
| isSuffix={true} | ||
| icon={isExpanded ? "ArrowDropUp" : "ArrowDropDown"} | ||
| variation={"teritiary"} | ||
| onClick={toggleViewMoreItems} | ||
| label = {isExpanded ? (StringManipulator("CAPITALIZEFIRSTLETTER", viewLessLabel) || "View Less") : (StringManipulator("CAPITALIZEFIRSTLETTER", viewMoreLabel) || "View More")} | ||
| size={"medium"} | ||
| ></Button> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Enhance accessibility and internationalization.
The rendering logic efficiently manages visibility and conditional styles. However, ensure that dynamic labels and icons are accessible and properly internationalized by using aria-labels.
- <Button
+ <Button aria-label={isExpanded ? "Collapse items" : "Expand items"}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const visibleChildren = sortedChildren.slice(0, visibleCount); | |
| const TimelineMolecule = ({ children }) => { | |
| return ( | |
| <div className="digit-timeline-molecule"> | |
| {Children.map(children, (child, index) => ( | |
| <Timeline {...child.props} isLastStep={index === Children.count(children) - 1} /> | |
| {Children.map(visibleChildren, (child, index) => ( | |
| <Timeline | |
| {...child.props} | |
| isLastStep={index === Children.count(visibleChildren) - 1} | |
| isNextActiveStep={currentActiveStep - 1 === index} | |
| /> | |
| ))} | |
| {initialVisibleCount && ( | |
| <div className="view-more-container"> | |
| <Button | |
| isSuffix={true} | |
| icon={isExpanded ? "ArrowDropUp" : "ArrowDropDown"} | |
| variation={"teritiary"} | |
| onClick={toggleViewMoreItems} | |
| label = {isExpanded ? (StringManipulator("CAPITALIZEFIRSTLETTER", viewLessLabel) || "View Less") : (StringManipulator("CAPITALIZEFIRSTLETTER", viewMoreLabel) || "View More")} | |
| size={"medium"} | |
| ></Button> | |
| </div> | |
| )} | |
| const visibleChildren = sortedChildren.slice(0, visibleCount); | |
| return ( | |
| <div className="digit-timeline-molecule"> | |
| {Children.map(visibleChildren, (child, index) => ( | |
| <Timeline | |
| {...child.props} | |
| isLastStep={index === Children.count(visibleChildren) - 1} | |
| isNextActiveStep={currentActiveStep - 1 === index} | |
| /> | |
| ))} | |
| {initialVisibleCount && ( | |
| <div className="view-more-container"> | |
| <Button | |
| isSuffix={true} | |
| icon={isExpanded ? "ArrowDropUp" : "ArrowDropDown"} | |
| variation={"teritiary"} | |
| onClick={toggleViewMoreItems} | |
| label = {isExpanded ? (StringManipulator("CAPITALIZEFIRSTLETTER", viewLessLabel) || "View Less") : (StringManipulator("CAPITALIZEFIRSTLETTER", viewMoreLabel) || "View More")} | |
| size={"medium"} | |
| aria-label={isExpanded ? "Collapse items" : "Expand items"} | |
| ></Button> | |
| </div> | |
| )} |
No description provided.