Dpg 2385 #75
Dpg 2385 #75
Conversation
WalkthroughThe recent updates primarily focus on enhancing the Panel component's success animation across various files. This includes styling adjustments in the CSS and SCSS files, version updates in HTML, and conditional rendering logic in JavaScript. Additionally, the Stepper component has been streamlined by removing unnecessary code, and storybook files for animations have been refined for better control and display. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
react/ui-components/src/atoms/Stepper.js (2)
Line range hint
69-77: Ensure accessibility by pairing mouse events with corresponding keyboard events in interactive elements.+ onKeyUp={handleKeyUp}
Line range hint
108-112: JSX elements without children should be self-closing to improve readability and maintain consistency.- <span className={`stepper-connect ${((index < currentStep - 1) || (index < activeSteps && index < activeSteps - 1 ) ) && "active"} ${direction ? direction : ""}`}></span> + <span className={`stepper-connect ${((index < currentStep - 1) || (index < activeSteps && index < activeSteps - 1 ) ) && "active"} ${direction ? direction : ""}`} />react/ui-components/src/atoms/Panels.js (1)
Line range hint
99-133: Refactor JSX to use self-closing tags and simplify boolean expressions.- <SVG.CheckCircleOutline - fill={"#FFFFFF"} - width={width} - height={height} - ></SVG.CheckCircleOutline> + <SVG.CheckCircleOutline fill={"#FFFFFF"} width={width} height={height} /> - <Animation - animationData={successAnimation} - width={width} - height={width} - loop={props?.animationProps?.loop === true ? true : false} - autoplay={props?.animationProps?.noAutoplay === true ? false : true} - ></Animation> + <Animation + animationData={successAnimation} + width={width} + height={width} + loop={props?.animationProps?.loop} + autoplay={!props?.animationProps?.noAutoplay} + /> - <SVG.ErrorOutline - fill={"#FFFFFF"} - width={width} - height={height} - ></SVG.ErrorOutline> + <SVG.ErrorOutline fill={"#FFFFFF"} width={width} height={height} /> - <Animation - animationData={errorAnimation} - width={width} - height={height} - loop={props?.animationProps?.loop === true ? true : false} - autoplay={props?.animationProps?.noAutoplay === true ? false : true} - ></Animation> + <Animation + animationData={errorAnimation} + width={width} + height={height} + loop={props?.animationProps?.loop} + autoplay={!props?.animationProps?.noAutoplay} + />
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (8)
react/css/package.jsonis excluded by!**/*.jsonreact/example/package.jsonis excluded by!**/*.jsonreact/modules/Project/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.jsonreact/ui-components/src/animations/success.jsonis excluded by!**/*.json
Files selected for processing (7)
- react/css/README.md (1 hunks)
- react/css/src/digitv2/components/panels.scss (2 hunks)
- react/example/public/index.html (1 hunks)
- react/ui-components/README.md (1 hunks)
- react/ui-components/src/atoms/Panels.js (2 hunks)
- react/ui-components/src/atoms/Stepper.js (1 hunks)
- react/ui-components/src/hoc/stories/Animation.stories.js (1 hunks)
Additional context used
LanguageTool
react/css/README.md
[uncategorized] ~20-~20: Possible missing comma found.
Context: ...it UI's ``` ## Usage After adding the dependency make sure you have this dependency in ...
[grammar] ~94-~94: This phrase is duplicated. You should probably use “DIGIT Core” only once.
Context: ...ishnakole-wtt-egov] ## Published from DIGIT Core Digit Core Repo (https://github.com/egovernments/D...
Markdownlint
react/css/README.md
92-92: Expected: 0 or 2; Actual: 1
Trailing spaces
94-94: Expected: 0 or 2; Actual: 1
Trailing spaces
42-42: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
90-90: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
94-94: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
41-41: null
Fenced code blocks should be surrounded by blank lines
89-89: null
Fenced code blocks should be surrounded by blank lines
95-95: null
Bare URL used
99-99: null
Files should end with a single newline characterreact/ui-components/README.md
43-43: Expected: 0 or 2; Actual: 1
Trailing spaces
98-98: Expected: 0 or 2; Actual: 1
Trailing spaces
57-57: Expected: 1; Actual: 2
Multiple consecutive blank lines
107-107: Expected: 1; Actual: 2
Multiple consecutive blank lines
108-108: Expected: 1; Actual: 3
Multiple consecutive blank lines
128-128: Expected: 1; Actual: 2
Multiple consecutive blank lines
147-147: Expected: 1; Actual: 2
Multiple consecutive blank lines
42-42: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
101-101: null
Fenced code blocks should be surrounded by blank lines
115-115: null
Fenced code blocks should be surrounded by blank lines
119-119: null
Fenced code blocks should be surrounded by blank lines
121-121: null
Fenced code blocks should be surrounded by blank lines
131-131: null
Bare URL used
139-139: null
Bare URL used
Biome
react/ui-components/src/atoms/Stepper.js
[error] 69-77: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.
[error] 108-112: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 45-45: This hook specifies more dependencies than necessary: activeSteps
[error] 72-72: Avoid using the index of an array as key property in an element.
react/ui-components/src/atoms/Panels.js
[error] 47-50: This else clause can be omitted because previous branches break early.
[error] 73-73: Useless case clause.
[error] 83-83: Useless case clause.
[error] 104-108: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 110-116: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 114-114: Unnecessary use of boolean literals in conditional expression.
[error] 115-115: Unnecessary use of boolean literals in conditional expression.
[error] 121-125: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 127-133: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 131-131: Unnecessary use of boolean literals in conditional expression.
[error] 132-132: Unnecessary use of boolean literals in conditional expression.
[error] 143-143: Missing key property for this element in iterable.
Additional comments not posted (7)
react/example/public/index.html (1)
12-12: Updated stylesheet link to version1.8.2-coreui.23aligns with the changelog updates.react/ui-components/src/hoc/stories/Animation.stories.js (2)
28-42: UpdatedTemplatefunction with additional styling properties enhances the visual presentation.
55-55: Updated animation data forSuccessAnimationandErrorAnimationcomponents aligns with the new animation assets.Also applies to: 61-61
react/css/src/digitv2/components/panels.scss (1)
5-21: Updated SCSS for.digit-panel-wrapperimproves responsiveness and visual consistency across different screen sizes.Also applies to: 25-38, 50-62, 66-79
react/css/README.md (1)
45-45: Updated changelog reflects the new version1.8.2-coreui.23and associated style updates.react/ui-components/README.md (1)
61-61: Updated changelog inreact/ui-components/README.mdaccurately reflects the new features and enhancements.react/ui-components/src/atoms/Panels.js (1)
96-96: LGTM! Dynamic class name adjustment enhances component flexibility.
No description provided.