Removeable tag update #66
Conversation
|
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThe recent updates enhance the styling and functionality of various React components and CSS files. Key improvements include the introduction of new CSS classes, adjustments to existing styles for better responsiveness, and the addition of new props to several UI components. Additionally, minor corrections in configuration files and updates to documentation ensure consistency and clarity across the project. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (9)
react/css/package.jsonis excluded by!**/*.jsonreact/example/package.jsonis excluded by!**/*.jsonreact/modules/Project/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.jsonreact/ui-components/yarn-error.logis excluded by!**/*.log,!**/*.logreact/yarn-error.logis excluded by!**/*.log,!**/*.log
Files selected for processing (6)
- react/css/README.md (1 hunks)
- react/css/src/digitv2/components/tagV2.scss (5 hunks)
- react/example/public/index.html (1 hunks)
- react/ui-components/README.md (1 hunks)
- react/ui-components/src/atoms/RemoveableTag.js (2 hunks)
- react/ui-components/src/hoc/stories/RemoveableTag.stories.js (1 hunks)
Files skipped from review due to trivial changes (1)
- react/ui-components/src/hoc/stories/RemoveableTag.stories.js
Additional comments not posted (6)
react/example/public/index.html (1)
12-12: Updated stylesheet link to version1.8.2-coreui.16correctly.react/ui-components/src/atoms/RemoveableTag.js (1)
4-4: The implementation of new propsonTagClickanderror, and the error handling logic usingErrorMessageare correctly added and integrated within theRemoveableTagcomponent.Also applies to: 9-9, 14-14, 26-52, 67-68
react/css/src/digitv2/components/tagV2.scss (1)
1-4: CSS updates including new classes and adjustments to existing ones are correctly applied to enhance responsiveness and styling.Also applies to: 20-20, 30-30, 41-47, 51-68
react/css/README.md (1)
45-45: Changelog updated correctly to reflect the new version1.8.2-coreui.16and the updates made toRemoveableTagstyles.react/ui-components/README.md (2)
61-61: Changelog updated correctly to reflect new features and props added to components likeRemoveableTagandErrorMessage.
Line range hint
96-124: Detailed documentation provided for the breaking changes in theToastcomponent, ensuring clear communication to developers about the newtypeprop.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (9)
react/css/README.md (5)
45-45: Update the changelog entry for1.8.2-coreui.17to include more specific details about the changes made toRemoveableTagstyles.
Line range hint
20-20: Consider adding a comma after "DIGIT-UI's" for better readability.
Line range hint
87-87: Remove the duplicated phrase "DIGIT Core" to enhance clarity.
Line range hint
88-88: Format the URL as a Markdown link for better readability and consistency.- Digit Core Repo (https://github.com/egovernments/Digit-Core/tree/digit-ui-core) + Digit Core Repo [Digit Core](https://github.com/egovernments/Digit-Core/tree/digit-ui-core)
Line range hint
92-92: Ensure the file ends with a single newline character to adhere to common coding standards.react/ui-components/README.md (4)
61-61: Update the changelog entry for0.0.1-beta.25to include more specific details about the changes made to theRemoveableTagcomponent.
Line range hint
57-57: Remove extra blank lines to improve the readability and maintain a clean document structure.Also applies to: 105-105, 124-124
Line range hint
108-108: Format the URLs as Markdown links for better readability and consistency.- Digit Core Repo (https://github.com/egovernments/Core-Platform/tree/digit-ui-core) + Digit Core Repo [Digit Core](https://github.com/egovernments/Core-Platform/tree/digit-ui-core) - Home Page (https://unified-dev.digit.org/storybook/) + Home Page [Storybook](https://unified-dev.digit.org/storybook/)
Line range hint
92-92: Add blank lines around the fenced code blocks to adhere to Markdown formatting standards.Also applies to: 96-96
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (9)
react/css/package.jsonis excluded by!**/*.jsonreact/example/package.jsonis excluded by!**/*.jsonreact/modules/Project/package.jsonis excluded by!**/*.jsonreact/modules/core/package.jsonis excluded by!**/*.jsonreact/modules/sample/package.jsonis excluded by!**/*.jsonreact/package.jsonis excluded by!**/*.jsonreact/ui-components/package.jsonis excluded by!**/*.jsonreact/ui-components/yarn-error.logis excluded by!**/*.log,!**/*.logreact/yarn-error.logis excluded by!**/*.log,!**/*.log
Files selected for processing (3)
- react/css/README.md (1 hunks)
- react/example/public/index.html (1 hunks)
- react/ui-components/README.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- react/example/public/index.html
Additional Context Used
Markdownlint (19)
react/css/README.md (9)
85: Expected: 0 or 2; Actual: 1
Trailing spaces
87: Expected: 0 or 2; Actual: 1
Trailing spaces
42: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
83: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
87: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
41: null
Fenced code blocks should be surrounded by blank lines
82: null
Fenced code blocks should be surrounded by blank lines
88: null
Bare URL used
92: null
Files should end with a single newline characterreact/ui-components/README.md (10)
43: Expected: 0 or 2; Actual: 1
Trailing spaces
57: Expected: 1; Actual: 2
Multiple consecutive blank lines
105: Expected: 1; Actual: 2
Multiple consecutive blank lines
124: Expected: 1; Actual: 2
Multiple consecutive blank lines
42: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
92: null
Fenced code blocks should be surrounded by blank lines
96: null
Fenced code blocks should be surrounded by blank lines
98: null
Fenced code blocks should be surrounded by blank lines
108: null
Bare URL used
116: null
Bare URL used
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- react/css/README.md (1 hunks)
- react/ui-components/README.md (1 hunks)
Additional Context Used
Markdownlint (19)
react/css/README.md (9)
86: Expected: 0 or 2; Actual: 1
Trailing spaces
88: Expected: 0 or 2; Actual: 1
Trailing spaces
42: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
84: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
88: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
41: null
Fenced code blocks should be surrounded by blank lines
83: null
Fenced code blocks should be surrounded by blank lines
89: null
Bare URL used
93: null
Files should end with a single newline characterreact/ui-components/README.md (10)
43: Expected: 0 or 2; Actual: 1
Trailing spaces
57: Expected: 1; Actual: 2
Multiple consecutive blank lines
106: Expected: 1; Actual: 2
Multiple consecutive blank lines
125: Expected: 1; Actual: 2
Multiple consecutive blank lines
42: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
93: null
Fenced code blocks should be surrounded by blank lines
97: null
Fenced code blocks should be surrounded by blank lines
99: null
Fenced code blocks should be surrounded by blank lines
109: null
Bare URL used
117: null
Bare URL used
Additional comments not posted (5)
react/css/README.md (1)
45-45: Update in changelog noted.The changelog correctly reflects the update to
RemoveableTagstyles in version1.8.2-coreui.17.react/ui-components/README.md (4)
61-61: Update in changelog noted.The changelog correctly reflects the update to
RemoveableTagcomponent to include error handling in version0.0.1-beta.25.
61-61: Update in changelog noted.The changelog correctly reflects the update to
ErrorMessagecomponent to include new props (showIcon,truncateMessage,maxLength) in version0.0.1-beta.23.
61-61: Update in changelog noted.The changelog correctly reflects the update to
Toastcomponent to consolidate type props (info,warning,error) into a singletypeprop in version0.0.1-beta.22.
61-61: Update in changelog noted.The changelog correctly reflects the addition of
categorySelectAllStatein thenestedmultiselectvariant ofmultiselectdropdownin version0.0.1-beta.21.
Swathi-eGov
force-pushed
the
RemoveableTag-Update
branch
from
9100791 to
73b4066
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
react/css/README.md (1)
Line range hint
88-88: Remove duplicated phrase and correct formatting issues.- ## Published from DIGIT Core Digit Core Repo (https://github.com/egovernments/Digit-Core/tree/digit-ui-core) + ## Published from DIGIT Core + Digit Core Repo (https://github.com/egovernments/Digit-Core/tree/digit-ui-core)react/ui-components/README.md (1)
Line range hint
57-57: Remove excessive blank lines to improve readability.- -
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .gitignore (1 hunks)
- react/css/README.md (1 hunks)
- react/css/tailwind.config.js (1 hunks)
- react/ui-components/.gitignore (1 hunks)
- react/ui-components/README.md (1 hunks)
- react/ui-components/src/atoms/RemoveableTag.js (2 hunks)
Files skipped from review due to trivial changes (3)
- .gitignore
- react/css/tailwind.config.js
- react/ui-components/.gitignore
Files skipped from review as they are similar to previous changes (1)
- react/ui-components/src/atoms/RemoveableTag.js
Additional Context Used
LanguageTool (3)
react/css/README.md (2)
Near line 20: Possible missing comma found.
Context: ...it UI's ``` ## Usage After adding the dependency make sure you have this dependency in ...
Near line 88: This phrase is duplicated. You should probably use “DIGIT Core” only once.
Context: ...ishnakole-wtt-egov] ## Published from DIGIT Core Digit Core Repo (https://github.com/egovernments/D...react/ui-components/README.md (1)
Near line 18: Possible missing comma found.
Context: ...ssion's ``` ## Usage After adding the dependency make sure you have this dependency in ...
Markdownlint (19)
react/css/README.md (9)
86: Expected: 0 or 2; Actual: 1
Trailing spaces
88: Expected: 0 or 2; Actual: 1
Trailing spaces
42: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
84: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
88: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
41: null
Fenced code blocks should be surrounded by blank lines
83: null
Fenced code blocks should be surrounded by blank lines
89: null
Bare URL used
93: null
Files should end with a single newline characterreact/ui-components/README.md (10)
43: Expected: 0 or 2; Actual: 1
Trailing spaces
57: Expected: 1; Actual: 2
Multiple consecutive blank lines
106: Expected: 1; Actual: 2
Multiple consecutive blank lines
125: Expected: 1; Actual: 2
Multiple consecutive blank lines
42: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
93: null
Fenced code blocks should be surrounded by blank lines
97: null
Fenced code blocks should be surrounded by blank lines
99: null
Fenced code blocks should be surrounded by blank lines
109: null
Bare URL used
117: null
Bare URL used
Additional comments not posted (2)
react/css/README.md (1)
45-45: Changelog update correctly reflects the newRemoveableTagstyles.react/ui-components/README.md (1)
61-61: Changelog update correctly reflects the newRemoveableTagcomponent enhancements.
No description provided.