-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added categorySelectAllState in nestedmultiselect #63
Conversation
WalkthroughThe recent update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (8)
react/example/package.json
is excluded by!**/*.json
react/modules/Project/package.json
is excluded by!**/*.json
react/modules/core/package.json
is excluded by!**/*.json
react/modules/sample/package.json
is excluded by!**/*.json
react/package.json
is excluded by!**/*.json
react/ui-components/package.json
is excluded by!**/*.json
react/ui-components/yarn-error.log
is excluded by!**/*.log
,!**/*.log
react/yarn-error.log
is excluded by!**/*.log
,!**/*.log
Files selected for processing (3)
- react/ui-components/README.md (1 hunks)
- react/ui-components/src/atoms/Dropdown.js (1 hunks)
- react/ui-components/src/atoms/MultiSelectDropdown.js (6 hunks)
Files skipped from review due to trivial changes (1)
- react/ui-components/src/atoms/Dropdown.js
Additional comments not posted (5)
react/ui-components/src/atoms/MultiSelectDropdown.js (5)
194-198
: Ensure that theonSelect
function is called with the correct parameters.
226-226
: Verify that theonSelect
function is called appropriately when clearing all selections.
252-256
: Confirm that theonSelect
function handles all selections correctly, especially in the context of nested multiselect scenarios.
285-289
: Check the logic for category selection to ensure it toggles the state correctly and updates the UI as expected.
292-307
: Review the implementation ofgetCategorySelectAllState
to ensure it accurately reflects the state of category selections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
react/ui-components/README.md (4)
Line range hint
43-43
: Remove trailing spaces.- yarn storybook + yarn storybook
Line range hint
57-57
: Remove multiple consecutive blank lines.- -Also applies to: 101-101
Line range hint
42-42
: Ensure headings are surrounded by blank lines.+ # Local Development +
Line range hint
85-85
: Provide descriptive text for URLs.- Digit Core Repo (https://github.com/egovernments/Core-Platform/tree/digit-ui-core) + Digit Core Repo: [Visit the repository](https://github.com/egovernments/Core-Platform/tree/digit-ui-core) - Home Page (https://unified-dev.digit.org/storybook/) + Home Page: [Explore the Storybook](https://unified-dev.digit.org/storybook/)Also applies to: 93-93
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- react/ui-components/README.md (1 hunks)
- react/ui-components/src/atoms/MultiSelectDropdown.js (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- react/ui-components/src/atoms/MultiSelectDropdown.js
Additional Context Used
LanguageTool (1)
react/ui-components/README.md (1)
Near line 18: A comma might be missing here.
Context: ...ssion's ``` ## Usage After adding the dependency make sure you have this dependency in ...
Additional comments not posted (3)
react/ui-components/README.md (3)
61-61
: Update the changelog entry for clarity and correct a typo.- 0.0.1-beta.21 Added categorySelectAllState in the nestedmultiselect variant of multiselectdropdown + 0.0.1-beta.21: Added categorySelectAllState in the nestedmultiselect variant of multiselectdropdown.
Line range hint
1-30
: Installation and usage instructions are clear and well-documented.
Line range hint
95-99
: Contributors section is well-documented and informative.
No description provided.